Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2943043002: Make dirty checking in check_gn_headers.py more robust (Closed)

Created:
3 years, 6 months ago by wychen
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make dirty checking in check_gn_headers.py more robust BUG=733898 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng Review-Url: https://codereview.chromium.org/2943043002 Cr-Commit-Position: refs/heads/master@{#480233} Committed: https://chromium.googlesource.com/chromium/src/+/67aabe00c117998937559c4847d85451abe8450b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/check_gn_headers.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
wychen
PTAL
3 years, 6 months ago (2017-06-16 02:57:26 UTC) #3
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-16 22:50:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943043002/1
3 years, 6 months ago (2017-06-16 22:52:13 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-17 00:12:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67aabe00c117998937559c4847d8...

Powered by Google App Engine
This is Rietveld 408576698