Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4373)

Unified Diff: build/check_gn_headers.py

Issue 2943043002: Make dirty checking in check_gn_headers.py more robust (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/check_gn_headers.py
diff --git a/build/check_gn_headers.py b/build/check_gn_headers.py
index 1db587a7d2ef2d403d0226281b28838a9721d379..f6ae8f5cac4166221e2dc1108050a4502a9daadd 100755
--- a/build/check_gn_headers.py
+++ b/build/check_gn_headers.py
@@ -148,9 +148,12 @@ def GetDepsPrefixes(q):
def IsBuildClean(out_dir):
cmd = [os.path.join(DEPOT_TOOLS_DIR, 'ninja'), '-C', out_dir, '-n']
- out = subprocess.check_output(cmd)
- return 'no work to do.' in out
-
+ try:
+ out = subprocess.check_output(cmd)
+ return 'no work to do.' in out
+ except Exception as e:
+ print e
+ return False
def ParseWhiteList(whitelist):
out = set()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698