[PresentationSevice] Use PresentationConnection to send messages from

[PresentationSevice] Use PresentationConnection to send messages from
MR to renderer.

- Use BrowserPresentationConnectionProxy to send messages to the
renderer PresentationConnection object.
- Move the RouteMessageObserver inheritance to the proxy.
- This allows us to unify the messaging codepath for offscreen and
non-offscreen presentations, and to remove the messaging APIs from
PresentationService / PresentationServiceClient.

BUG=687011
Review-Url: https://codereview.chromium.org/2943033003
Cr-Commit-Position: refs/heads/master@{#481265}
Committed: https://chromium.googlesource.com/chromium/src/+/e086a06b613955abb1293eecef0d4c0cda0244f7

[imcheng, 2017-06-16 04:22:00]

Description was changed from

==========
[PresentationSevice] Use PresentationConnection to send messages from
MR to renderer.

- Use BrowserPresentationConnectionProxy to send messages to the
renderer PresentationConnection object.
- Move the RouteMessageObserver inheritance to the proxy.
- This allows us to unify the messaging codepath for offscreen and
non-offscreen presentations, and to remove the messaging APIs from
PresentationService / PresentationServiceClient.

BUG=687011
==========

to

==========
[PresentationSevice] Use PresentationConnection to send messages from
MR to renderer.

- Use BrowserPresentationConnectionProxy to send messages to the
renderer PresentationConnection object.
- Move the RouteMessageObserver inheritance to the proxy.
- This allows us to unify the messaging codepath for offscreen and
non-offscreen presentations, and to remove the messaging APIs from
PresentationService / PresentationServiceClient.

TODO: rename receiver -> renderer?
BUG=687011
==========

[imcheng, 2017-06-16 04:22:07]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 04:22:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 05:01:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 05:01:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[imcheng, 2017-06-16 20:04:15]

Description was changed from

==========
[PresentationSevice] Use PresentationConnection to send messages from
MR to renderer.

- Use BrowserPresentationConnectionProxy to send messages to the
renderer PresentationConnection object.
- Move the RouteMessageObserver inheritance to the proxy.
- This allows us to unify the messaging codepath for offscreen and
non-offscreen presentations, and to remove the messaging APIs from
PresentationService / PresentationServiceClient.

TODO: rename receiver -> renderer?
BUG=687011
==========

to

==========
[PresentationSevice] Use PresentationConnection to send messages from
MR to renderer.

- Use BrowserPresentationConnectionProxy to send messages to the
renderer PresentationConnection object.
- Move the RouteMessageObserver inheritance to the proxy.
- This allows us to unify the messaging codepath for offscreen and
non-offscreen presentations, and to remove the messaging APIs from
PresentationService / PresentationServiceClient.

BUG=687011
==========

[imcheng, 2017-06-16 20:04:22]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 20:04:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[imcheng, 2017-06-16 20:05:09]

Patchset #1 (id:1) has been deleted

[imcheng, 2017-06-16 20:05:15]

Patchset #1 (id:20001) has been deleted

[imcheng, 2017-06-16 20:05:32]

imcheng@chromium.org changed reviewers:
+ zhaobin@chromium.org

[imcheng, 2017-06-16 20:05:33]

Bin: PTAL, thanks!

[zhaobin, 2017-06-19 23:36:48]

lgtm

May add a unit test for BrowserPresentationConnectionProxy::OnMessagesReceived
(or later)

Could you please make sure it works fine with DIAL devices? We used to have lots
of problems with DIAL when changing connection message related code :)

[imcheng, 2017-06-20 17:36:55]

On 2017/06/19 23:36:48, zhaobin wrote:
> lgtm
> 
> May add a unit test for BrowserPresentationConnectionProxy::OnMessagesReceived
> (or later)
> 
> Could you please make sure it works fine with DIAL devices? We used to have
lots
> of problems with DIAL when changing connection message related code :)

Added unit test for BrowserPresentationConnectionProxy.

Also tested Cast and DIAL manually. I will also make sure the integration tests
pass.

[imcheng, 2017-06-20 17:39:20]

imcheng@chromium.org changed reviewers:
+ avi@chromium.org, dcheng@chromium.org

[imcheng, 2017-06-20 17:39:21]

avi, PTAL at content/public/browser/presentation_service_delegate.h
dcheng, PTAL at
third_party/WebKit/public/platform/modules/presentation/presentation.mojom

thanks!

[imcheng, 2017-06-20 17:42:13]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 17:42:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 19:42:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 19:42:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dcheng, 2017-06-20 21:35:34]

ipc lgtm

https://codereview.chromium.org/2943033003/diff/60001/chrome/browser/media/ro...
File chrome/browser/media/router/browser_presentation_connection_proxy.cc
(right):

https://codereview.chromium.org/2943033003/diff/60001/chrome/browser/media/ro...
chrome/browser/media/router/browser_presentation_connection_proxy.cc:19:
LOG_IF(ERROR, !success)
Nit: DLOG? Not sure that users will get much value out of this log.

[imcheng, 2017-06-21 16:59:29]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 16:59:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[imcheng, 2017-06-21 17:00:14]

Avi: friendly ping to review presentation_service_delegate.h thanks!

https://codereview.chromium.org/2943033003/diff/60001/chrome/browser/media/ro...
File chrome/browser/media/router/browser_presentation_connection_proxy.cc
(right):

https://codereview.chromium.org/2943033003/diff/60001/chrome/browser/media/ro...
chrome/browser/media/router/browser_presentation_connection_proxy.cc:19:
LOG_IF(ERROR, !success)
On 2017/06/20 21:35:34, dcheng wrote:
> Nit: DLOG? Not sure that users will get much value out of this log.

Done.

[Avi (use Gerrit), 2017-06-21 17:30:04]

On 2017/06/21 17:00:14, imcheng wrote:
> Avi: friendly ping to review presentation_service_delegate.h thanks!
> 
>
https://codereview.chromium.org/2943033003/diff/60001/chrome/browser/media/ro...
> File chrome/browser/media/router/browser_presentation_connection_proxy.cc
> (right):
> 
>
https://codereview.chromium.org/2943033003/diff/60001/chrome/browser/media/ro...
> chrome/browser/media/router/browser_presentation_connection_proxy.cc:19:
> LOG_IF(ERROR, !success)
> On 2017/06/20 21:35:34, dcheng wrote:
> > Nit: DLOG? Not sure that users will get much value out of this log.
> 
> Done.

Thank you for the ping! presentation_service_delegate.h LGTM

[commit-bot: I haz the power, 2017-06-21 18:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 18:54:35]

Dry run: This issue passed the CQ dry run.

[imcheng, 2017-06-21 18:55:16]

The CQ bit was checked by imcheng@chromium.org

[imcheng, 2017-06-21 18:55:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
zhaobin@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2943033003/#ps80001
(title: "LOG -> DLOG")

[commit-bot: I haz the power, 2017-06-21 18:55:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 19:04:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498071316723520,
"parent_rev": "ce4098a0c69d36bb055bec82d13348cf2f8810d0", "commit_rev":
"e086a06b613955abb1293eecef0d4c0cda0244f7"}

[commit-bot: I haz the power, 2017-06-21 19:04:19]

Description was changed from

==========
[PresentationSevice] Use PresentationConnection to send messages from
MR to renderer.

- Use BrowserPresentationConnectionProxy to send messages to the
renderer PresentationConnection object.
- Move the RouteMessageObserver inheritance to the proxy.
- This allows us to unify the messaging codepath for offscreen and
non-offscreen presentations, and to remove the messaging APIs from
PresentationService / PresentationServiceClient.

BUG=687011
==========

to

==========
[PresentationSevice] Use PresentationConnection to send messages from
MR to renderer.

- Use BrowserPresentationConnectionProxy to send messages to the
renderer PresentationConnection object.
- Move the RouteMessageObserver inheritance to the proxy.
- This allows us to unify the messaging codepath for offscreen and
non-offscreen presentations, and to remove the messaging APIs from
PresentationService / PresentationServiceClient.

BUG=687011

Review-Url: https://codereview.chromium.org/2943033003
Cr-Commit-Position: refs/heads/master@{#481265}
Committed:
https://chromium.googlesource.com/chromium/src/+/e086a06b613955abb1293eecef0d...
==========

[commit-bot: I haz the power, 2017-06-21 19:04:21]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e086a06b613955abb1293eecef0d...