Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Unified Diff: third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Issue 2943033003: [PresentationSevice] Use PresentationConnection to send messages from (Closed)
Patch Set: LOG -> DLOG Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/presentation/presentation_dispatcher_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/modules/presentation/presentation.mojom
diff --git a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
index f68bc43ae6088c116f5852c0b273db2b8a6727cb..2c4f7ff0446e5adbfd06cdce373a86bbe51dd4b3 100644
--- a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
+++ b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
@@ -98,9 +98,14 @@ interface PresentationService {
ReconnectPresentation(array<url.mojom.Url> presentation_urls, string? presentation_id)
=> (PresentationInfo? presentation_info, PresentationError? error);
- // Called in StartPresentation's callback function for offscreen presentation only.
- // It passes in controlling frame's PresentationConnection and
- // PresentationConnectionRequest to PresentationService.
+ // Notifies the service that a PresentationConnection has been started.
+ // |controller_connection_ptr| is a handle to a PresentationConnection in
+ // the page that started the presentation (aka the "controller"). This can be
+ // used by PresentationService to send messages to the controller
+ // PresentationConnection, for example.
+ // The PresentationService should bind |receiver_connection_request| to a
+ // PresentationConnection implementation in order to receive messages and
+ // commands issued by the controller PresentationConnection.
SetPresentationConnection(
PresentationInfo presentation_info,
PresentationConnection controller_connection_ptr,
@@ -112,13 +117,6 @@ interface PresentationService {
// Called when terminate() is called by the frame.
Terminate(url.mojom.Url presentation_url, string presentation_id);
-
- // Starts listening for messages on the presentation identified by |presentation_info|.
- // Messages will be received in
- // PresentationServiceClient::OnConnectionMessagesReceived.
- // This is called after a connection has been established to the presentation
- // from the frame.
- ListenForConnectionMessages(PresentationInfo presentation_info);
};
interface PresentationServiceClient {
@@ -161,8 +159,4 @@ interface PresentationServiceClient {
OnConnectionClosed(PresentationInfo presentation_info,
PresentationConnectionCloseReason reason,
string message);
-
- // See PresentationService::ListenForConnectionMessages.
- OnConnectionMessagesReceived(PresentationInfo presentation_info,
- array<PresentationConnectionMessage> messages);
};
« no previous file with comments | « content/renderer/presentation/presentation_dispatcher_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698