Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2942913002: [ObjC ARC] Converts ios/chrome/browser/ui/tabs:tabs to ARC. (Closed)

Created:
3 years, 6 months ago by stkhapugin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/tabs:tabs to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2942913002 Cr-Commit-Position: refs/heads/master@{#481275} Committed: https://chromium.googlesource.com/chromium/src/+/9097b515c720bbba706d05366986991f6653bfad

Patch Set 1 #

Patch Set 2 : fix_error #

Total comments: 4

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -65 lines) Patch
M ios/chrome/browser/ui/tabs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_strip_controller.mm View 1 2 25 chunks +37 lines, -43 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_strip_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_strip_view.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_view.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_view.mm View 7 chunks +17 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/tabs/target_frame_cache.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
stkhapugin
ptal
3 years, 6 months ago (2017-06-16 16:12:49 UTC) #7
marq (ping after 24h)
LGTM after fixes. https://codereview.chromium.org/2942913002/diff/20001/ios/chrome/browser/ui/tabs/tab_strip_controller.mm File ios/chrome/browser/ui/tabs/tab_strip_controller.mm (right): https://codereview.chromium.org/2942913002/diff/20001/ios/chrome/browser/ui/tabs/tab_strip_controller.mm#newcode434 ios/chrome/browser/ui/tabs/tab_strip_controller.mm:434: ; Remove bare ; https://codereview.chromium.org/2942913002/diff/20001/ios/chrome/browser/ui/tabs/tab_strip_controller.mm#newcode710 ios/chrome/browser/ui/tabs/tab_strip_controller.mm:710: ...
3 years, 6 months ago (2017-06-19 11:03:49 UTC) #11
stkhapugin
Thanks, PTAL https://codereview.chromium.org/2942913002/diff/20001/ios/chrome/browser/ui/tabs/tab_strip_controller.mm File ios/chrome/browser/ui/tabs/tab_strip_controller.mm (right): https://codereview.chromium.org/2942913002/diff/20001/ios/chrome/browser/ui/tabs/tab_strip_controller.mm#newcode434 ios/chrome/browser/ui/tabs/tab_strip_controller.mm:434: ; On 2017/06/19 11:03:49, marq (ping after ...
3 years, 6 months ago (2017-06-20 14:38:57 UTC) #12
marq (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-21 11:59:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942913002/40001
3 years, 6 months ago (2017-06-21 16:30:53 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 19:26:54 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9097b515c720bbba706d05366986...

Powered by Google App Engine
This is Rietveld 408576698