[ObjC ARC] Converts ios/chrome/browser/ui/tabs:tabs to ARC.

ios/chrome/browser/ui/tabs/tab_view.mm

 
 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/tabs/tab_view.h"
 
 #include "base/i18n/rtl.h"
 #include "base/ios/ios_util.h"
 #include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+
 #include "base/strings/sys_string_conversions.h"
 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
 #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
 #import "ios/chrome/browser/ui/image_util.h"
 #include "ios/chrome/browser/ui/rtl_geometry.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/third_party/material_components_ios/src/components/ActivityIndicator/src/MaterialActivityIndicator.h"
 #import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
 #include "third_party/google_toolbox_for_mac/src/iPhone/GTMFadeTruncatingLabel.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 #import "ui/gfx/ios/uikit_util.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 
 // Tab close button insets.
 const CGFloat kTabCloseTopInset = -1.0;
 const CGFloat kTabCloseLeftInset = 0.0;
 const CGFloat kTabCloseBottomInset = 0.0;
 const CGFloat kTabCloseRightInset = 0.0;
 const CGFloat kTabBackgroundLeftCapInset = 24.0;
 const CGFloat kFaviconLeftInset = 23.5;
 const CGFloat kFaviconVerticalOffset = 2.0;
 const CGFloat kTabStripLineMargin = 2.5;
 const CGFloat kTabStripLineHeight = 0.5;
 const CGFloat kCloseButtonHorizontalShift = 15;
 const CGFloat kCloseButtonVerticalShift = 4.0;
 const CGFloat kTitleLeftMargin = 8.0;
 const CGFloat kTitleRightMargin = 0.0;
 
 const CGFloat kCloseButtonSize = 24.0;
 const CGFloat kFaviconSize = 16.0;
 }
 
 @interface TabView () {
   // Close button for this tab.
   UIButton* _closeButton;
 
   // View that draws the tab title.
   GTMFadeTruncatingLabel* _titleLabel;
 
   // Background image for this tab.
-  base::scoped_nsobject<UIImageView> _backgroundImageView;
+  UIImageView* _backgroundImageView;
   // This view is used to draw a separator line at the bottom of the tab view.
   // This view is hidden when the tab view is in a selected state.
-  base::scoped_nsobject<UIView> _lineSeparator;
+  UIView* _lineSeparator;
   BOOL _incognitoStyle;
 
   // Set to YES when the layout constraints have been initialized.
   BOOL _layoutConstraintsInitialized;
 
   // Image view used to draw the favicon and spinner.
-  base::scoped_nsobject<UIImageView> _faviconView;
+  UIImageView* _faviconView;
 
   // If |YES|, this view will adjust its appearance and draw as a collapsed tab.
   BOOL _collapsed;
 
-  base::scoped_nsobject<MDCActivityIndicator> _activityIndicator;
-
-  base::mac::ObjCPropertyReleaser _propertyReleaser_TabView;
+  MDCActivityIndicator* _activityIndicator;
 }
 @end
 
 @interface TabView (Private)
 
 // Creates the close button, favicon button, and title.
 - (void)createButtonsAndLabel;
 
 // Updates this tab's line separator color based on the current incognito style.
 - (void)updateLineSeparator;
@@ skipping 21 matching lines @@
 @implementation TabView
 
 @synthesize closeButton = _closeButton;
 @synthesize titleLabel = _titleLabel;
 @synthesize collapsed = _collapsed;
 @synthesize background = background_;
 @synthesize incognitoStyle = _incognitoStyle;
 
 - (id)initWithEmptyView:(BOOL)emptyView selected:(BOOL)selected {
   if ((self = [super initWithFrame:CGRectZero])) {
-    _propertyReleaser_TabView.Init(self, [TabView class]);
     [self setOpaque:NO];
     [self createCommonViews];
     // -setSelected only calls -updateBackgroundImage if the selected state
     // changes.  |isSelected| defaults to NO, so if |selected| is also NO,
     // -updateBackgroundImage needs to be called explicitly.
     [self setSelected:selected];
     [self updateLineSeparator];
     [self updateBackgroundImage:selected];
     if (!emptyView)
       [self createButtonsAndLabel];
@@ skipping 100 matching lines @@
   // Account for the trapezoidal shape of the tab.  Inset the tab bounds by
   // (y = -2.2x + 56), determined empirically from looking at the tab background
   // images.
   CGFloat inset = MAX(0.0, (point.y - 56) / -2.2);
   return CGRectContainsPoint(CGRectInset([self bounds], inset, 0), point);
 }
 
 #pragma mark - Private
 
 - (void)createCommonViews {
-  _backgroundImageView.reset([[UIImageView alloc] init]);
+  _backgroundImageView = [[UIImageView alloc] init];
   [_backgroundImageView setTranslatesAutoresizingMaskIntoConstraints:NO];
   [self addSubview:_backgroundImageView];
 
-  _lineSeparator.reset([[UIView alloc] initWithFrame:CGRectZero]);
+  _lineSeparator = [[UIView alloc] initWithFrame:CGRectZero];
   [_lineSeparator setTranslatesAutoresizingMaskIntoConstraints:NO];
   [self addSubview:_lineSeparator];
 }
 
 - (void)addCommonConstraints {
   NSDictionary* commonViewsDictionary = @{
-    @"backgroundImageView" : _backgroundImageView.get(),
-    @"lineSeparator" : _lineSeparator.get()
+    @"backgroundImageView" : _backgroundImageView,
+    @"lineSeparator" : _lineSeparator
   };
   NSArray* commonConstraints = @[
     @"H:|-0-[backgroundImageView]-0-|",
     @"V:|-0-[backgroundImageView]-0-|",
     @"H:|-tabStripLineMargin-[lineSeparator]-tabStripLineMargin-|",
     @"V:[lineSeparator(==tabStripLineHeight)]-0-|",
   ];
   NSDictionary* commonMetrics = @{
     @"tabStripLineMargin" : @(kTabStripLineMargin),
     @"tabStripLineHeight" : @(kTabStripLineHeight)
   };
   ApplyVisualConstraintsWithMetrics(commonConstraints, commonViewsDictionary,
                                     commonMetrics, self);
 }
 
 - (void)createButtonsAndLabel {
-  _closeButton = [[UIButton buttonWithType:UIButtonTypeCustom] retain];
+  _closeButton = [UIButton buttonWithType:UIButtonTypeCustom];
   [_closeButton setTranslatesAutoresizingMaskIntoConstraints:NO];
   [_closeButton setImage:[UIImage imageNamed:@"tabstrip_tab_close"]
                 forState:UIControlStateNormal];
   [_closeButton setImage:[UIImage imageNamed:@"tabstrip_tab_close_pressed"]
                 forState:UIControlStateHighlighted];
   [_closeButton setContentEdgeInsets:UIEdgeInsetsMake(kTabCloseTopInset,
                                                       kTabCloseLeftInset,
                                                       kTabCloseBottomInset,
                                                       kTabCloseRightInset)];
   [_closeButton setAccessibilityLabel:l10n_util::GetNSString(
                                           IDS_IOS_TOOLS_MENU_CLOSE_TAB)];
   [self addSubview:_closeButton];
 
   // Add fade truncating label.
   _titleLabel = [[GTMFadeTruncatingLabel alloc] initWithFrame:CGRectZero];
   [_titleLabel setTranslatesAutoresizingMaskIntoConstraints:NO];
   [_titleLabel setFont:[MDCTypography body1Font]];
   // Setting NSLineBreakByCharWrapping fixes an issue where the beginning of the
   // text is truncated for RTL text writing direction. Anyway since the label is
   // only one line and the end of the text is faded behind a gradient mask, it
   // is visually almost equivalent to NSLineBreakByClipping.
   [_titleLabel setLineBreakMode:NSLineBreakByCharWrapping];
 
   [_titleLabel setTextAlignment:NSTextAlignmentNatural];
   [self addSubview:_titleLabel];
 
   CGRect faviconFrame = CGRectMake(0, 0, kFaviconSize, kFaviconSize);
-  _faviconView.reset([[UIImageView alloc] initWithFrame:faviconFrame]);
+  _faviconView = [[UIImageView alloc] initWithFrame:faviconFrame];
   [_faviconView setTranslatesAutoresizingMaskIntoConstraints:NO];
   [_faviconView setContentMode:UIViewContentModeScaleAspectFit];
   [_faviconView setImage:[self defaultFaviconImage]];
   [_faviconView setAccessibilityIdentifier:@"Favicon"];
   [self addSubview:_faviconView];
 
-  _activityIndicator.reset(
-      [[MDCActivityIndicator alloc] initWithFrame:faviconFrame]);
+  _activityIndicator =
+      [[MDCActivityIndicator alloc] initWithFrame:faviconFrame];
   [_activityIndicator setTranslatesAutoresizingMaskIntoConstraints:NO];
   [_activityIndicator
       setCycleColors:@[ [[MDCPalette cr_bluePalette] tint500] ]];
   [_activityIndicator setRadius:ui::AlignValueToUpperPixel(kFaviconSize / 2)];
   [self addSubview:_activityIndicator];
 }
 
 - (void)addButtonsAndLabelConstraints {
   // Constraints on the Top bar, snapshot view, and shadow view.
   NSDictionary* viewsDictionary = @{
@@ skipping 55 matching lines @@
   [_closeButton setImage:normalImage forState:UIControlStateNormal];
   [_closeButton setImage:pressedImage forState:UIControlStateHighlighted];
 }
 
 - (UIImage*)defaultFaviconImage {
   return self.incognitoStyle ? [UIImage imageNamed:@"default_favicon_incognito"]
                              : [UIImage imageNamed:@"default_favicon"];
 }
 
 @end