Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2942833004: Add article link to play promises rejection error message (Closed)

Created:
3 years, 6 months ago by François Beaufort
Modified:
3 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jam, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, nessy, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add article link to play promises rejection error message BUG=728294 Review-Url: https://codereview.chromium.org/2942833004 Cr-Commit-Position: refs/heads/master@{#480025} Committed: https://chromium.googlesource.com/chromium/src/+/804cd4b03e108b85d1cc71d251608b11b6f033f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-networkState-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/media-source/mediasource-duration-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/W3C/audio/events/event_pause_manual-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/W3C/audio/events/event_play_manual-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/W3C/audio/paused/paused_true_during_pause-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/W3C/video/events/event_pause_manual-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/W3C/video/events/event_play_manual-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/W3C/video/paused/paused_true_during_pause-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-play-promise.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-display-none-crash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-play-pause-events-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
mlamouri (slow - plz ping)
I see that some places in the code add the url in a "(see: $URL)". ...
3 years, 6 months ago (2017-06-16 09:00:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942833004/1
3 years, 6 months ago (2017-06-16 11:22:05 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 12:58:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/804cd4b03e108b85d1cc71d25160...

Powered by Google App Engine
This is Rietveld 408576698