Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2942833004: Add article link to play promises rejection error message (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-play-pause-events-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 485f7fd414646532875f85d38df533bf1911ffdc..97fe01e17dd85b12d7ca578ff188f41ca395d968 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -893,9 +893,9 @@ void HTMLMediaElement::InvokeLoadAlgorithm() {
// 4.6.2 - Take pending play promises and reject pending play promises
// with the result and an "AbortError" DOMException.
- RejectPlayPromises(
- kAbortError,
- "The play() request was interrupted by a new load request.");
+ RejectPlayPromises(kAbortError,
+ "The play() request was interrupted by a new load "
+ "request. https://goo.gl/LdLk22");
}
// 4.7 - If seeking is true, set it to false.
@@ -3943,14 +3943,15 @@ void HTMLMediaElement::RejectScheduledPlayPromises() {
// used by the object, the string isn't saved.
DCHECK(play_promise_error_code_ == kAbortError ||
play_promise_error_code_ == kNotSupportedError);
- if (play_promise_error_code_ == kAbortError)
- RejectPlayPromisesInternal(
- kAbortError,
- "The play() request was interrupted by a call to pause().");
- else
+ if (play_promise_error_code_ == kAbortError) {
+ RejectPlayPromisesInternal(kAbortError,
+ "The play() request was interrupted by a call "
+ "to pause(). https://goo.gl/LdLk22");
+ } else {
RejectPlayPromisesInternal(
kNotSupportedError,
"Failed to load because no supported source was found.");
+ }
}
void HTMLMediaElement::RejectPlayPromises(ExceptionCode code,
« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-play-pause-events-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698