[sync] Don't show an error icon when sync isn't signed in

[sync] Don't show an error icon when sync isn't signed in

BUG=732688, 732684
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2942473002
Cr-Commit-Position: refs/heads/master@{#479477}
Committed: https://chromium.googlesource.com/chromium/src/+/b0f420e81d69cf2712f7847a364b2d7d3d59195c

[Patrick Noland, 2017-06-13 23:11:41]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 23:12:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 23:53:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 23:53:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2017-06-14 17:22:18]

Can you add more comments to the CL description?

lgtm

https://codereview.chromium.org/2942473002/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.cc (right):

https://codereview.chromium.org/2942473002/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.cc:792: IsSyncRequested();
"IsSyncRequested()" is a confusing name. It seems like it should imply that the
user has signed in. Oh well.

Can you update the comments around the definition of kSyncSuppressStart? They
seem to be outdated.

[Patrick Noland, 2017-06-14 17:56:34]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 17:57:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 19:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 19:47:43]

Dry run: This issue passed the CQ dry run.

[Patrick Noland, 2017-06-14 19:56:20]

> Can you update the comments around the definition of kSyncSuppressStart? 
> They seem to be outdated.

Done.

[Patrick Noland, 2017-06-14 19:56:30]

The CQ bit was checked by pnoland@chromium.org

[Patrick Noland, 2017-06-14 19:56:31]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2942473002/#ps20001
(title: "make isSyncConfirmationNeeded virtual, add comments")

[commit-bot: I haz the power, 2017-06-14 19:57:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 20:01:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497470190870760,
"parent_rev": "6ad31af8c32c1a7bb67acb1d17469328ae7265b8", "commit_rev":
"b0f420e81d69cf2712f7847a364b2d7d3d59195c"}

[commit-bot: I haz the power, 2017-06-14 20:01:43]

Description was changed from

==========
[sync] Don't show an error icon when sync isn't signed in

BUG=732688, 732684
R=skym@chromium.org
==========

to

==========
[sync] Don't show an error icon when sync isn't signed in

BUG=732688, 732684
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2942473002
Cr-Commit-Position: refs/heads/master@{#479477}
Committed:
https://chromium.googlesource.com/chromium/src/+/b0f420e81d69cf2712f7847a364b...
==========

[commit-bot: I haz the power, 2017-06-14 20:01:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b0f420e81d69cf2712f7847a364b...