Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: components/browser_sync/profile_sync_service.cc

Issue 2942473002: [sync] Don't show an error icon when sync isn't signed in (Closed)
Patch Set: make isSyncConfirmationNeeded virtual, add comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_sync/profile_sync_service.h ('k') | components/sync/base/pref_names.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_sync/profile_sync_service.cc
diff --git a/components/browser_sync/profile_sync_service.cc b/components/browser_sync/profile_sync_service.cc
index 6efd0397c036c4c31812accbb4f2e58031e8a55e..353c36f18ece4db263408af28cc6845580973a40 100644
--- a/components/browser_sync/profile_sync_service.cc
+++ b/components/browser_sync/profile_sync_service.cc
@@ -788,7 +788,7 @@ void ProfileSyncService::SetFirstSetupComplete() {
bool ProfileSyncService::IsSyncConfirmationNeeded() const {
DCHECK(thread_checker_.CalledOnValidThread());
- return !IsFirstSetupInProgress() && !IsFirstSetupComplete() &&
+ return IsSignedIn() && !IsFirstSetupInProgress() && !IsFirstSetupComplete() &&
IsSyncRequested();
}
« no previous file with comments | « components/browser_sync/profile_sync_service.h ('k') | components/sync/base/pref_names.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698