Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2942133002: Reland of Android: Refactor BuildInfo to use less jni and remove StrictMode exception (Closed)

Created:
3 years, 6 months ago by agrieve
Modified:
3 years, 6 months ago
Reviewers:
mgersh, Torne
CC:
chromium-reviews, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Android: Refactor BuildInfo to use less jni and remove StrictMode exception Reason for reland: Had a DCHECK that was removing an important expression. Ensured that net_unittests failed locally, and was fixed with change. No behaviour change expected. Strictly a simplifying refactoring. Review-Url: https://codereview.chromium.org/2942133002 Cr-Commit-Position: refs/heads/master@{#480057} Committed: https://chromium.googlesource.com/chromium/src/+/8e74adc3a8fd143e8624deeeb07ee73750553dd2

Patch Set 1 #

Patch Set 2 : Take important line out of DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -134 lines) Patch
M base/android/build_info.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M base/android/build_info.cc View 1 2 chunks +34 lines, -27 lines 0 comments Download
M base/android/java/src/org/chromium/base/BuildInfo.java View 1 5 chunks +29 lines, -98 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
agrieve
Created Reland of Android: Refactor BuildInfo to use less jni and remove StrictMode exception
3 years, 6 months ago (2017-06-16 01:42:48 UTC) #1
Torne
lgtm
3 years, 6 months ago (2017-06-16 14:53:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942133002/100001
3 years, 6 months ago (2017-06-16 15:54:27 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 15:57:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8e74adc3a8fd143e8624deeeb07e...

Powered by Google App Engine
This is Rietveld 408576698