Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2835113004: Revert of Android: Refactor BuildInfo to use less jni and remove StrictMode exception (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
mgersh, Torne
CC:
chromium-reviews, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Refactor BuildInfo to use less jni and remove StrictMode exception (patchset #2 id:20001 of https://codereview.chromium.org/2825233002/ ) Reason for revert: Likely causing net_unittest failures. e.g.: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Marshmallow%2064bit%20Builder/builds/8704/ Original issue's description: > Android: Refactor BuildInfo to use less jni and remove StrictMode exception > > No behaviour change expected. Strictly a simplifying refactoring. > > Review-Url: https://codereview.chromium.org/2825233002 > Cr-Commit-Position: refs/heads/master@{#466630} > Committed: https://chromium.googlesource.com/chromium/src/+/c4cb0d38f0bd26578120775e9c09be813b5215c0 TBR=torne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2835113004 Cr-Commit-Position: refs/heads/master@{#466633} Committed: https://chromium.googlesource.com/chromium/src/+/91522d0519823a43060738914a65b71119b669d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -76 lines) Patch
M base/android/build_info.h View 2 chunks +9 lines, -10 lines 0 comments Download
M base/android/build_info.cc View 2 chunks +31 lines, -37 lines 0 comments Download
M base/android/java/src/org/chromium/base/BuildInfo.java View 5 chunks +98 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
agrieve
Created Revert of Android: Refactor BuildInfo to use less jni and remove StrictMode exception
3 years, 8 months ago (2017-04-24 15:43:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835113004/1
3 years, 8 months ago (2017-04-24 15:44:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/91522d0519823a43060738914a65b71119b669d7
3 years, 8 months ago (2017-04-24 15:45:16 UTC) #9
agrieve
3 years, 6 months ago (2017-06-16 01:42:47 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2942133002/ by agrieve@chromium.org.

The reason for reverting is: Will update when ready.

Powered by Google App Engine
This is Rietveld 408576698