chrome/browser/ui/omnibox/omnibox_view_browsertest.cc - Issue 2942013002: [omnibox] Constrain 'IsSelectAll()' to be more accurate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 2942013002: [omnibox] Constrain 'IsSelectAll()' to be more accurate (Closed)

Patch Set: Missed a fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

index 6feaf298a41fcefd8d47ab3992486ecf69cbbb3f..145bb78a7da9c0b20eeb10b3bd3907eccfed3a43 100644

--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

@@ -855,7 +855,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, BasicTextOperations) {

// Delete the content

ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_DELETE, 0));

- EXPECT_TRUE(omnibox_view->IsSelectAll());

+ EXPECT_FALSE(omnibox_view->IsSelectAll());

omnibox_view->GetSelectionBounds(&start, &end);

EXPECT_EQ(0U, start);

EXPECT_EQ(0U, end);