chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 2942013002: [omnibox] Constrain 'IsSelectAll()' to be more accurate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 2942013002: [omnibox] Constrain 'IsSelectAll()' to be more accurate (Closed)

Patch Set: Missed a fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index d50af54bbbb597c135d96fa60b1c60c741434e6d..08d0278b1be752cf8fc1e4982fec8d5f4210f712 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -435,7 +435,7 @@ void OmniboxViewViews::SetCaretPos(size_t caret_pos) {

bool OmniboxViewViews::IsSelectAll() const {

// TODO(oshima): IME support.

- return text() == GetSelectedText();

+ return !text().empty() && text() == GetSelectedText();

}

bool OmniboxViewViews::DeleteAtEndPressed() {

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | no next file » | no next file with comments »