chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 2942013002: [omnibox] Constrain 'IsSelectAll()' to be more accurate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 2942013002: [omnibox] Constrain 'IsSelectAll()' to be more accurate (Closed)

Patch Set: Missed a fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index 4296eb52e181554e1e68b87695dd4bb19a7f0450..c38ea786368bed245c5adcd59050953b96db6fa2 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -369,6 +369,8 @@ bool OmniboxViewMac::IsSelectAll() const {

if (![field_ currentEditor])

return true;

const NSRange all_range = NSMakeRange(0, GetTextLength());

+ if (all_range.length == 0)

+ return false;

return NSEqualRanges(all_range, GetSelectedRange());

}