Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2941963002: Remove batcharchive dependency on common.IsDirectory (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unused import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M client/cmd/isolate/batch_archive.go View 1 2 chunks +3 lines, -2 lines 0 comments Download
M client/internal/common/utils.go View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mcgreevy
3 years, 6 months ago (2017-06-15 05:55:40 UTC) #2
mithro
lgtm
3 years, 6 months ago (2017-06-15 06:14:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941963002/20001
3 years, 6 months ago (2017-06-15 06:15:09 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 06:23:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/35426aab5e558df793b116a5f0c516633a32376b

Powered by Google App Engine
This is Rietveld 408576698