Remove batcharchive dependency on common.IsDirectory

client/cmd/isolate/batch_archive.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package main
 
 import (
         "encoding/json"
         "errors"
         "fmt"
         "io"
         "os"
         "path/filepath"
         "strings"
         "sync"
         "time"
 
         "github.com/maruel/subcommands"
 
         "github.com/luci/luci-go/client/archiver"
-        "github.com/luci/luci-go/client/internal/common"
         "github.com/luci/luci-go/client/isolate"
         "github.com/luci/luci-go/common/auth"
         "github.com/luci/luci-go/common/data/text/units"
         "github.com/luci/luci-go/common/isolated"
         "github.com/luci/luci-go/common/isolatedclient"
 )
 
 func cmdBatchArchive(defaultAuthOpts auth.Options) *subcommands.Command {
         return &subcommands.Command{
                 UsageLine: "batcharchive <options> file1 file2 ...",
@@ skipping 177 matching lines @@
                 Dir     string
                 Version int
         }{}
         if err := json.NewDecoder(r).Decode(data); err != nil {
                 return nil, fmt.Errorf("failed to decode: %s", err)
         }
 
         if data.Version != isolate.IsolatedGenJSONVersion {
                 return nil, fmt.Errorf("invalid version %d", data.Version)
         }
-        if !common.IsDirectory(data.Dir) {
+
+        if fileInfo, err := os.Stat(data.Dir); err != nil || !fileInfo.IsDir() {
                 return nil, fmt.Errorf("invalid dir %s", data.Dir)
         }
+
         opts, err := parseArchiveCMD(data.Args, data.Dir)
         if err != nil {
                 return nil, fmt.Errorf("invalid archive command: %s", err)
         }
         return opts, nil
 }
 
 // strippedIsolatedName returns the base name of an isolated path, with the extension (if any) removed.
 func strippedIsolatedName(isolated string) string {
         name := filepath.Base(isolated)
@@ skipping 40 matching lines @@
                 fmt.Fprintf(a.GetErr(), "%s: %s\n", a.GetName(), err)
                 return 1
         }
         defer cl.Close()
         if err := c.main(a, args); err != nil {
                 fmt.Fprintf(a.GetErr(), "%s: %s\n", a.GetName(), err)
                 return 1
         }
         return 0
 }