Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 2941943002: Only enable kUsePermissionManagerForMediaRequests when the PermissionRequestManager is used (Closed)

Created:
3 years, 6 months ago by raymes
Modified:
3 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only enable kUsePermissionManagerForMediaRequests when the PermissionRequestManager is used This adds a check which ensures that the PermissionManager is used to request permission for Media requests only when the PermissionRequestManager is enabled. If it's not enabled, the grouped request won't work correctly. BUG=596786 Review-Url: https://codereview.chromium.org/2941943002 Cr-Commit-Position: refs/heads/master@{#480017} Committed: https://chromium.googlesource.com/chromium/src/+/9ea317b97a564286aadf81bfe3d2bcb1d0e642cc

Patch Set 1 #

Patch Set 2 : Only enable kUsePermissionManagerForMediaRequests when the PermissionRequestManager is used #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/media/webrtc/media_stream_devices_controller.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
raymes
3 years, 6 months ago (2017-06-15 04:57:52 UTC) #2
Timothy Loh
On 2017/06/15 04:57:52, raymes wrote: lgtm
3 years, 6 months ago (2017-06-15 06:57:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941943002/20001
3 years, 6 months ago (2017-06-16 10:02:26 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 11:10:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ea317b97a564286aadf81bfe3d2...

Powered by Google App Engine
This is Rietveld 408576698