Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/media/webrtc/media_stream_devices_controller.cc

Issue 2941943002: Only enable kUsePermissionManagerForMediaRequests when the PermissionRequestManager is used (Closed)
Patch Set: Only enable kUsePermissionManagerForMediaRequests when the PermissionRequestManager is used Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h" 5 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h"
6 6
7 #include <map> 7 #include <map>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
11 #include "base/feature_list.h" 11 #include "base/feature_list.h"
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "base/metrics/histogram_macros.h" 13 #include "base/metrics/histogram_macros.h"
14 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
15 #include "base/values.h" 15 #include "base/values.h"
16 #include "chrome/browser/content_settings/host_content_settings_map_factory.h" 16 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
17 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 17 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
18 #include "chrome/browser/media/webrtc/media_capture_devices_dispatcher.h" 18 #include "chrome/browser/media/webrtc/media_capture_devices_dispatcher.h"
19 #include "chrome/browser/media/webrtc/media_stream_capture_indicator.h" 19 #include "chrome/browser/media/webrtc/media_stream_capture_indicator.h"
20 #include "chrome/browser/media/webrtc/media_stream_device_permissions.h" 20 #include "chrome/browser/media/webrtc/media_stream_device_permissions.h"
21 #include "chrome/browser/permissions/permission_manager.h" 21 #include "chrome/browser/permissions/permission_manager.h"
22 #include "chrome/browser/permissions/permission_request_manager.h"
22 #include "chrome/browser/permissions/permission_result.h" 23 #include "chrome/browser/permissions/permission_result.h"
23 #include "chrome/browser/permissions/permission_uma_util.h" 24 #include "chrome/browser/permissions/permission_uma_util.h"
24 #include "chrome/browser/permissions/permission_util.h" 25 #include "chrome/browser/permissions/permission_util.h"
25 #include "chrome/browser/profiles/profile.h" 26 #include "chrome/browser/profiles/profile.h"
26 #include "chrome/browser/ui/browser.h" 27 #include "chrome/browser/ui/browser.h"
27 #include "chrome/common/chrome_features.h" 28 #include "chrome/common/chrome_features.h"
28 #include "chrome/common/pref_names.h" 29 #include "chrome/common/pref_names.h"
29 #include "chrome/grit/generated_resources.h" 30 #include "chrome/grit/generated_resources.h"
30 #include "components/content_settings/core/browser/host_content_settings_map.h" 31 #include "components/content_settings/core/browser/host_content_settings_map.h"
31 #include "components/content_settings/core/common/content_settings_pattern.h" 32 #include "components/content_settings/core/common/content_settings_pattern.h"
(...skipping 14 matching lines...) Expand all
46 #include <vector> 47 #include <vector>
47 48
48 #include "chrome/browser/android/preferences/pref_service_bridge.h" 49 #include "chrome/browser/android/preferences/pref_service_bridge.h"
49 #include "chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h" 50 #include "chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h"
50 #include "chrome/browser/permissions/permission_dialog_delegate.h" 51 #include "chrome/browser/permissions/permission_dialog_delegate.h"
51 #include "chrome/browser/permissions/permission_update_infobar_delegate_android. h" 52 #include "chrome/browser/permissions/permission_update_infobar_delegate_android. h"
52 #include "chrome/grit/theme_resources.h" 53 #include "chrome/grit/theme_resources.h"
53 #include "content/public/browser/android/content_view_core.h" 54 #include "content/public/browser/android/content_view_core.h"
54 #include "ui/android/window_android.h" 55 #include "ui/android/window_android.h"
55 #else // !defined(OS_ANDROID) 56 #else // !defined(OS_ANDROID)
56 #include "chrome/browser/permissions/permission_request_manager.h"
57 #include "ui/vector_icons/vector_icons.h" 57 #include "ui/vector_icons/vector_icons.h"
58 #endif 58 #endif
59 59
60 using content::BrowserThread; 60 using content::BrowserThread;
61 61
62 namespace { 62 namespace {
63 63
64 // Returns true if the given ContentSettingsType is being requested in 64 // Returns true if the given ContentSettingsType is being requested in
65 // |request|. 65 // |request|.
66 bool ContentTypeIsRequested(ContentSettingsType type, 66 bool ContentTypeIsRequested(ContentSettingsType type,
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 std::unique_ptr<MediaStreamDevicesController> controller( 458 std::unique_ptr<MediaStreamDevicesController> controller(
459 new MediaStreamDevicesController(web_contents, request, callback)); 459 new MediaStreamDevicesController(web_contents, request, callback));
460 460
461 // Show a prompt if needed. 461 // Show a prompt if needed.
462 bool is_asking_for_audio = controller->IsAskingForAudio(); 462 bool is_asking_for_audio = controller->IsAskingForAudio();
463 bool is_asking_for_video = controller->IsAskingForVideo(); 463 bool is_asking_for_video = controller->IsAskingForVideo();
464 if (is_asking_for_audio || is_asking_for_video) { 464 if (is_asking_for_audio || is_asking_for_video) {
465 Profile* profile = 465 Profile* profile =
466 Profile::FromBrowserContext(web_contents->GetBrowserContext()); 466 Profile::FromBrowserContext(web_contents->GetBrowserContext());
467 if (base::FeatureList::IsEnabled( 467 if (base::FeatureList::IsEnabled(
468 features::kUsePermissionManagerForMediaRequests)) { 468 features::kUsePermissionManagerForMediaRequests) &&
469 PermissionRequestManager::IsEnabled()) {
469 std::vector<ContentSettingsType> content_settings_types; 470 std::vector<ContentSettingsType> content_settings_types;
470 471
471 if (is_asking_for_audio) 472 if (is_asking_for_audio)
472 content_settings_types.push_back(CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC); 473 content_settings_types.push_back(CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC);
473 if (is_asking_for_video) { 474 if (is_asking_for_video) {
474 content_settings_types.push_back( 475 content_settings_types.push_back(
475 CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA); 476 CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA);
476 } 477 }
477 478
478 PermissionManager::Get(profile)->RequestPermissions( 479 PermissionManager::Get(profile)->RequestPermissions(
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 } 777 }
777 } 778 }
778 779
779 // Don't approve device requests if the tab was hidden. 780 // Don't approve device requests if the tab was hidden.
780 // TODO(qinmin): Add a test for this. http://crbug.com/396869. 781 // TODO(qinmin): Add a test for this. http://crbug.com/396869.
781 // TODO(raymes): Shouldn't this apply to all permissions not just audio/video? 782 // TODO(raymes): Shouldn't this apply to all permissions not just audio/video?
782 return web_contents_->GetRenderWidgetHostView()->IsShowing(); 783 return web_contents_->GetRenderWidgetHostView()->IsShowing();
783 #endif 784 #endif
784 return true; 785 return true;
785 } 786 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698