Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: ios/web_view/test/chrome_web_view_kvo_inttest.mm

Issue 2941763003: Cleanup ios_web_view integration tests. (Closed)
Patch Set: Addressed review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web_view/test/BUILD.gn ('k') | ios/web_view/test/chrome_web_view_restorable_state_inttest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/test/chrome_web_view_kvo_inttest.mm
diff --git a/ios/web_view/test/chrome_web_view_kvo_inttest.mm b/ios/web_view/test/chrome_web_view_kvo_inttest.mm
index c7badae19ae000bb4b08f1301d939ed4757ecd31..139b6facbe656cef03371ba20994f601126ec5c8 100644
--- a/ios/web_view/test/chrome_web_view_kvo_inttest.mm
+++ b/ios/web_view/test/chrome_web_view_kvo_inttest.mm
@@ -5,13 +5,12 @@
#import <ChromeWebView/ChromeWebView.h>
#import <Foundation/Foundation.h>
-#import "base/mac/scoped_nsobject.h"
#include "base/strings/stringprintf.h"
#import "base/strings/sys_string_conversions.h"
#import "ios/testing/wait_util.h"
#import "ios/web_view/test/chrome_web_view_test.h"
#import "ios/web_view/test/observer.h"
-#import "ios/web_view/test/web_view_interaction_test_util.h"
+#import "ios/web_view/test/web_view_test_util.h"
#import "net/base/mac/url_conversions.h"
#include "testing/gtest_mac.h"
#include "url/gurl.h"
@@ -20,23 +19,11 @@
#error "This file requires ARC support."
#endif
+namespace ios_web_view {
+
// Tests that the KVO compliant properties of CWVWebView correctly report
// changes.
-class ChromeWebViewKvoTest : public ios_web_view::ChromeWebViewTest {
- protected:
- ChromeWebViewKvoTest() {
- CWVWebViewConfiguration* configuration =
- [CWVWebViewConfiguration defaultConfiguration];
- web_view_.reset([[CWVWebView alloc]
- initWithFrame:CGRectMake(0.0, 0.0, 100.0, 100.0)
- configuration:configuration]);
- }
-
- // Web View used to listen for expected KVO property changes.
- base::scoped_nsobject<CWVWebView> web_view_;
-};
-
-namespace ios_web_view {
+typedef ios_web_view::ChromeWebViewTest ChromeWebViewKvoTest;
// Tests that CWVWebView correctly reports |canGoBack| and |canGoForward| state.
TEST_F(ChromeWebViewKvoTest, CanGoBackForward) {
« no previous file with comments | « ios/web_view/test/BUILD.gn ('k') | ios/web_view/test/chrome_web_view_restorable_state_inttest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698