Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2941623004: Generate enum/getters/setters/mappings for isolation. (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
shend
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for isolation. Currently, the isolation property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EIsolation enum and use the generated CSSValueID <-> EIsolation mappings. Diff: https://gist.github.com/3920a62cb3b9844256b997d6a4e06672/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2941623004 Cr-Commit-Position: refs/heads/master@{#479352} Committed: https://chromium.googlesource.com/chromium/src/+/0923b5913aa087a0ffd8695a49aae2931e0e5c56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -41 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
nainar
shend@, PTAL? Thanks!
3 years, 6 months ago (2017-06-14 07:40:49 UTC) #4
shend
lgtm
3 years, 6 months ago (2017-06-14 07:42:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941623004/1
3 years, 6 months ago (2017-06-14 11:39:33 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 11:43:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0923b5913aa087a0ffd8695a49aa...

Powered by Google App Engine
This is Rietveld 408576698