Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2936113003: Make EIsolation an enum class. (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
shend
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EIsolation an enum class. This patch makes EIsolation an enum class for type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2936113003 Cr-Commit-Position: refs/heads/master@{#479350} Committed: https://chromium.googlesource.com/chromium/src/+/f47fa8b0e9979ff1ab2b7d1c651480941472f86d

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
nainar
shend@, PTAL? Thanks!
3 years, 6 months ago (2017-06-14 07:24:43 UTC) #4
shend
lgtm with comment https://codereview.chromium.org/2936113003/diff/1/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 File third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 (right): https://codereview.chromium.org/2936113003/diff/1/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5#newcode476 third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5:476: name: "RespectImageOrientation", what happened here? https://codereview.chromium.org/2936113003/diff/1/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5#newcode485 ...
3 years, 6 months ago (2017-06-14 07:26:29 UTC) #5
nainar
https://codereview.chromium.org/2936113003/diff/1/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 File third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 (right): https://codereview.chromium.org/2936113003/diff/1/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5#newcode476 third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5:476: name: "RespectImageOrientation", On 2017/06/14 at 07:26:28, shend wrote: > ...
3 years, 6 months ago (2017-06-14 07:29:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936113003/20001
3 years, 6 months ago (2017-06-14 11:33:09 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 11:37:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f47fa8b0e9979ff1ab2b7d1c6514...

Powered by Google App Engine
This is Rietveld 408576698