Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2941623003: [Chromoting] Use latest API to check whether DX capturer is supported (Closed)

Created:
3 years, 6 months ago by Hzj_jie
Modified:
3 years, 5 months ago
Reviewers:
Sergey Ulanov, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Use latest API to check whether DX capturer is supported After change https://codereview.chromium.org/2933893003/, a scoped_refptr of DxgiDuplicatorController should always be instantiated to ensure the ScreenCapturerWinDirectx::IsSupported() or similar functions won't initialize and unload DxgiDuplicatorController for several times. BUG=webrtc:7808 Review-Url: https://codereview.chromium.org/2941623003 Cr-Commit-Position: refs/heads/master@{#482890} Committed: https://chromium.googlesource.com/chromium/src/+/be1b07405c191a417dcb18086e562d54595812f3

Patch Set 1 #

Total comments: 4

Patch Set 2 : Resolve review comments #

Total comments: 10

Patch Set 3 : Remove DirectX-Capturer attribute, use Windows version instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -38 lines) Patch
M remoting/host/host_attributes.cc View 1 2 6 chunks +33 lines, -38 lines 0 comments Download

Messages

Total messages: 57 (48 generated)
Hzj_jie
3 years, 5 months ago (2017-06-26 21:18:19 UTC) #32
Sergey Ulanov
https://codereview.chromium.org/2941623003/diff/90001/remoting/host/host_attributes.cc File remoting/host/host_attributes.cc (right): https://codereview.chromium.org/2941623003/diff/90001/remoting/host/host_attributes.cc#newcode70 remoting/host/host_attributes.cc:70: if (webrtc::ScreenCapturerWinDirectx::RetrieveD3dInfo(&info)) { Where is the change that made ...
3 years, 5 months ago (2017-06-26 23:55:23 UTC) #35
Hzj_jie
https://codereview.chromium.org/2941623003/diff/90001/remoting/host/host_attributes.cc File remoting/host/host_attributes.cc (right): https://codereview.chromium.org/2941623003/diff/90001/remoting/host/host_attributes.cc#newcode70 remoting/host/host_attributes.cc:70: if (webrtc::ScreenCapturerWinDirectx::RetrieveD3dInfo(&info)) { On 2017/06/26 23:55:23, Sergey Ulanov wrote: ...
3 years, 5 months ago (2017-06-27 04:37:28 UTC) #40
Do not use (sergeyu)
https://codereview.chromium.org/2941623003/diff/110001/remoting/host/host_attributes.cc File remoting/host/host_attributes.cc (right): https://codereview.chromium.org/2941623003/diff/110001/remoting/host/host_attributes.cc#newcode35 remoting/host/host_attributes.cc:35: void AppendAttribute(std::string* result, const char* attribute) { It would ...
3 years, 5 months ago (2017-06-27 05:54:44 UTC) #42
joedow
https://codereview.chromium.org/2941623003/diff/110001/remoting/host/host_attributes.cc File remoting/host/host_attributes.cc (right): https://codereview.chromium.org/2941623003/diff/110001/remoting/host/host_attributes.cc#newcode82 remoting/host/host_attributes.cc:82: LOG(WARNING) << "Failed to retrieve current session id."; If ...
3 years, 5 months ago (2017-06-27 15:44:59 UTC) #44
Hzj_jie
https://codereview.chromium.org/2941623003/diff/110001/remoting/host/host_attributes.cc File remoting/host/host_attributes.cc (right): https://codereview.chromium.org/2941623003/diff/110001/remoting/host/host_attributes.cc#newcode35 remoting/host/host_attributes.cc:35: void AppendAttribute(std::string* result, const char* attribute) { On 2017/06/27 ...
3 years, 5 months ago (2017-06-27 23:03:06 UTC) #49
Sergey Ulanov
lgtm
3 years, 5 months ago (2017-06-28 00:44:26 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941623003/130001
3 years, 5 months ago (2017-06-28 05:02:40 UTC) #53
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 05:15:24 UTC) #56
Message was sent while issue was closed.
Committed patchset #3 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/be1b07405c191a417dcb18086e56...

Powered by Google App Engine
This is Rietveld 408576698