Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2933893003: Add reference counter of DxgiDuplicatorController to unload DXGI components (Closed)

Created:
3 years, 6 months ago by Hzj_jie
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add reference counter of DxgiDuplicatorController to unload DXGI components On Windows, only four applications can use DXGI duplication APIs concurrently. So this change adds a reference counter of DxgiDuplicatorController to unload DXGI components when the reference counter reaches 0. BUG=webrtc:7808 Review-Url: https://codereview.webrtc.org/2933893003 Cr-Commit-Position: refs/heads/master@{#18668} Committed: https://chromium.googlesource.com/external/webrtc/+/6dd77c4d898c8ac9116d29a07bdd4244e3301030

Patch Set 1 #

Patch Set 2 : Add reference counter for DxgiDuplicatorController #

Total comments: 3

Patch Set 3 : unique_ptr -> scoped_refptr #

Total comments: 9

Patch Set 4 : Resolve review comments #

Patch Set 5 : Avoid copy-constructor of std::atomic_int #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -30 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_win.cc View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h View 1 2 3 4 4 chunks +22 lines, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc View 1 2 3 4 3 chunks +24 lines, -6 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.cc View 1 2 3 4 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 47 (31 generated)
Hzj_jie
3 years, 6 months ago (2017-06-13 07:39:27 UTC) #7
Do not use (sergeyu)
Bug 679523 is closed. Can you please open a separate bug for this fix? How ...
3 years, 6 months ago (2017-06-13 18:36:50 UTC) #9
Hzj_jie
On 2017/06/13 18:36:50, Do not use (sergeyu) wrote: > Bug 679523 is closed. Can you ...
3 years, 6 months ago (2017-06-13 18:41:52 UTC) #10
Hzj_jie
On 2017/06/13 18:41:52, Hzj_jie wrote: > On 2017/06/13 18:36:50, Do not use (sergeyu) wrote: > ...
3 years, 6 months ago (2017-06-13 21:23:54 UTC) #12
Hzj_jie
Code has been updated.
3 years, 6 months ago (2017-06-14 04:23:54 UTC) #18
Do not use (sergeyu)
https://codereview.webrtc.org/2933893003/diff/20001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h File webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h (right): https://codereview.webrtc.org/2933893003/diff/20001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h#newcode51 webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h:51: std::unique_ptr<DxgiDuplicatorController, ReferenceReleaser>; Do we really need this instead of ...
3 years, 6 months ago (2017-06-15 19:25:20 UTC) #19
Hzj_jie
https://codereview.webrtc.org/2933893003/diff/20001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h File webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h (right): https://codereview.webrtc.org/2933893003/diff/20001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h#newcode51 webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h:51: std::unique_ptr<DxgiDuplicatorController, ReferenceReleaser>; On 2017/06/15 19:25:19, Do not use (sergeyu) ...
3 years, 6 months ago (2017-06-15 20:32:02 UTC) #20
Sergey Ulanov
https://codereview.webrtc.org/2933893003/diff/20001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h File webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h (right): https://codereview.webrtc.org/2933893003/diff/20001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h#newcode51 webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h:51: std::unique_ptr<DxgiDuplicatorController, ReferenceReleaser>; On 2017/06/15 20:32:02, Hzj_jie wrote: > On ...
3 years, 6 months ago (2017-06-16 05:59:59 UTC) #21
Hzj_jie
On 2017/06/16 05:59:59, Sergey Ulanov wrote: > https://codereview.webrtc.org/2933893003/diff/20001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h > File webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h (right): > > https://codereview.webrtc.org/2933893003/diff/20001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h#newcode51 ...
3 years, 6 months ago (2017-06-16 18:45:37 UTC) #23
Hzj_jie
Code has been updated.
3 years, 6 months ago (2017-06-16 21:43:37 UTC) #28
Sergey Ulanov
https://codereview.webrtc.org/2933893003/diff/40001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc File webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc (right): https://codereview.webrtc.org/2933893003/diff/40001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc#newcode29 webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc:29: std::atomic_int DxgiDuplicatorController::refcount_(0); Does this value need to be static? ...
3 years, 6 months ago (2017-06-19 18:52:43 UTC) #29
Hzj_jie
https://codereview.webrtc.org/2933893003/diff/40001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc File webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc (right): https://codereview.webrtc.org/2933893003/diff/40001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc#newcode29 webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc:29: std::atomic_int DxgiDuplicatorController::refcount_(0); On 2017/06/19 18:52:43, Sergey Ulanov wrote: > ...
3 years, 6 months ago (2017-06-19 20:19:47 UTC) #38
Do not use (sergeyu)
lgtm https://codereview.webrtc.org/2933893003/diff/40001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h File webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h (right): https://codereview.webrtc.org/2933893003/diff/40001/webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h#newcode75 webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h:75: // Deprecated: use "GetRefence()" instead. On 2017/06/19 20:19:46, ...
3 years, 6 months ago (2017-06-19 20:54:44 UTC) #40
Sergey Ulanov
lgtm from the right account
3 years, 6 months ago (2017-06-19 20:55:41 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2933893003/80001
3 years, 6 months ago (2017-06-19 20:57:42 UTC) #44
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 20:59:51 UTC) #47
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/6dd77c4d898c8ac9116d29a07...

Powered by Google App Engine
This is Rietveld 408576698