Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2941283002: fuchsia: Use new, qualified error names, disable old names. (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, danakj+watch_chromium.org, sadrul, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

fuchsia: Use new, qualified error names, disable old names. BUG=731280 R=scottmg@chromium.org Review-Url: https://codereview.chromium.org/2941283002 . Cr-Commit-Position: refs/heads/master@{#480089} Committed: https://chromium.googlesource.com/chromium/src/+/5a0405f8f3607547ae3872063a1c50b2c95989b7

Patch Set 1 #

Total comments: 2

Patch Set 2 : don have #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -28 lines) Patch
M base/message_loop/message_pump_fuchsia.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M base/process/kill_fuchsia.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/process/launch_fuchsia.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/process/process_fuchsia.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M base/process/process_handle_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/rand_util_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/config/fuchsia/BUILD.gn View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Nico
So much existing code to convert already!
3 years, 6 months ago (2017-06-16 15:32:13 UTC) #3
scottmg
lgtm https://codereview.chromium.org/2941283002/diff/1/build/config/fuchsia/BUILD.gn File build/config/fuchsia/BUILD.gn (right): https://codereview.chromium.org/2941283002/diff/1/build/config/fuchsia/BUILD.gn#newcode16 build/config/fuchsia/BUILD.gn:16: # Don'have include error codes that aren't prefixed ...
3 years, 6 months ago (2017-06-16 16:57:20 UTC) #5
Nico
Thanks! https://codereview.chromium.org/2941283002/diff/1/build/config/fuchsia/BUILD.gn File build/config/fuchsia/BUILD.gn (right): https://codereview.chromium.org/2941283002/diff/1/build/config/fuchsia/BUILD.gn#newcode16 build/config/fuchsia/BUILD.gn:16: # Don'have include error codes that aren't prefixed ...
3 years, 6 months ago (2017-06-16 17:23:26 UTC) #6
Nico
3 years, 6 months ago (2017-06-16 17:25:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5a0405f8f3607547ae3872063a1c50b2c95989b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698