Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: base/process/kill_fuchsia.cc

Issue 2941283002: fuchsia: Use new, qualified error names, disable old names. (Closed)
Patch Set: don have Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_pump_fuchsia.cc ('k') | base/process/launch_fuchsia.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/kill_fuchsia.cc
diff --git a/base/process/kill_fuchsia.cc b/base/process/kill_fuchsia.cc
index 273802c4c4fa1d369968b355f03f2cb8e74003e4..6567571e094925ff2f09b7f859769f69e268a20c 100644
--- a/base/process/kill_fuchsia.cc
+++ b/base/process/kill_fuchsia.cc
@@ -15,9 +15,9 @@ namespace base {
bool KillProcessGroup(ProcessHandle process_group_id) {
// |process_group_id| is really a job on Fuchsia.
mx_status_t status = mx_task_kill(process_group_id);
- DLOG_IF(ERROR, status != NO_ERROR)
+ DLOG_IF(ERROR, status != MX_OK)
<< "unable to terminate job " << process_group_id;
- return status == NO_ERROR;
+ return status == MX_OK;
}
TerminationStatus GetTerminationStatus(ProcessHandle handle, int* exit_code) {
@@ -25,7 +25,7 @@ TerminationStatus GetTerminationStatus(ProcessHandle handle, int* exit_code) {
mx_status_t status =
mx_object_get_info(handle, MX_INFO_PROCESS, &process_info,
sizeof(process_info), nullptr, nullptr);
- if (status != NO_ERROR) {
+ if (status != MX_OK) {
DLOG(ERROR) << "unable to get termination status for " << handle;
*exit_code = 0;
return TERMINATION_STATUS_NORMAL_TERMINATION;
@@ -53,7 +53,7 @@ void EnsureProcessTerminated(Process process) {
// forcefully if it hasn't already exited.
mx_signals_t signals;
if (mx_object_wait_one(process.Handle(), MX_TASK_TERMINATED,
- mx_deadline_after(MX_SEC(2)), &signals) == NO_ERROR) {
+ mx_deadline_after(MX_SEC(2)), &signals) == MX_OK) {
DCHECK(signals & MX_TASK_TERMINATED);
// If already signaled, then the process is terminated.
return;
« no previous file with comments | « base/message_loop/message_pump_fuchsia.cc ('k') | base/process/launch_fuchsia.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698