Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2940903002: Revert of Defaulting verify_names flag to True (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Defaulting verify_names flag to True (patchset #1 id:1 of https://codereview.chromium.org/2924023003/ ) Reason for revert: Broke a bunch of unittests in tools/perf Original issue's description: > Defaulting verify_names flag to True > > BUG=chromium:720002 > > Review-Url: https://codereview.chromium.org/2924023003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/749afc0150fd58e07fa009b3a09ad1eb49a7b7ca TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2940903002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c9212cbf522072a1011063b212da5ee7baeb56df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M telemetry/telemetry/story/story_set.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
ashleymarie1
Created Revert of Defaulting verify_names flag to True
3 years, 6 months ago (2017-06-14 17:30:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940903002/1
3 years, 6 months ago (2017-06-14 17:31:04 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 17:31:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698