Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2924023003:
Defaulting verify_names flag to True (Closed)
|
Created:
3 years, 6 months ago by ashleymarie1 Modified:
3 years, 6 months ago Reviewers:
nednguyen CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionDefaulting verify_names flag to True
BUG=chromium:720002
Review-Url: https://codereview.chromium.org/2924023003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/749afc0150fd58e07fa009b3a09ad1eb49a7b7ca
Review-Url: https://codereview.chromium.org/2924023003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f2164910296e3ea00d02b0918ff6f2d842e42934
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 48 (41 generated)
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ashleymarie@chromium.org changed reviewers: + nednguyen@google.com
Ready to flip the switch to verifying that all stories in story sets have names by default!
Yay! lgtm
The CQ bit was checked by ashleymarie@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497383645879630, "parent_rev":
"c351f52eee49388f85f01a01034a6a1795aa1460", "commit_rev":
"749afc0150fd58e07fa009b3a09ad1eb49a7b7ca"}
Message was sent while issue was closed.
Description was changed from ========== Defaulting verify_names flag to True BUG=chromium:720002 ========== to ========== Defaulting verify_names flag to True BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2924023003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2940903002/ by ashleymarie@chromium.org. The reason for reverting is: Broke a bunch of unittests in tools/perf.
Message was sent while issue was closed.
Description was changed from ========== Defaulting verify_names flag to True BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2924023003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ========== to ========== Defaulting verify_names flag to True BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2924023003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
The CQ bit was checked by ashleymarie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ashleymarie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2924023003/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497903836466280,
"parent_rev": "8f9cc5018f428b0a6569520fa7b6449ecfd29467", "commit_rev":
"f2164910296e3ea00d02b0918ff6f2d842e42934"}
Message was sent while issue was closed.
Description was changed from ========== Defaulting verify_names flag to True BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2924023003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ========== to ========== Defaulting verify_names flag to True BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2924023003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... Review-Url: https://codereview.chromium.org/2924023003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
