Discourage new use of CallJavascriptFunctionUnsafe() via PRESUBMIT

Discourage new use of CallJavascriptFunctionUnsafe() via PRESUBMIT

R=dpranke@chromium.org
BUG=717296
Review-Url: https://codereview.chromium.org/2940893003
Cr-Commit-Position: refs/heads/master@{#479596}
Committed: https://chromium.googlesource.com/chromium/src/+/b6f4fde989a97dff96696a0c469a531c4b20557d

[Dan Beam, 2017-06-15 02:13:07]

Description was changed from

==========
Discourage new use of CallJavascriptFunction() via PRESUBMIT

R=dpranke@chromium.org
BUG=717296
==========

to

==========
Discourage new use of CallJavascriptFunctionUnsafe() via PRESUBMIT

R=dpranke@chromium.org
BUG=717296
==========

[Dan Beam, 2017-06-15 02:13:30]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-06-15 02:30:05]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 02:30:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 02:38:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 02:38:44]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-06-15 02:47:35]

lgtm

[Dirk Pranke, 2017-06-15 02:47:57]

assuming someone who knows something about this also approves it, I should say
:).

[Dan Beam, 2017-06-15 03:07:46]

dbeam@chromium.org changed reviewers:
+ tommycli@chromium.org

[Dan Beam, 2017-06-15 03:07:47]

+tommycli@

see Dirk's comment

[tommycli, 2017-06-15 03:57:58]

On 2017/06/15 03:07:47, Dan Beam wrote:
> +tommycli@
> 
> see Dirk's comment

Lgtm assuming Dirk has verified that the presubmit syntax is well formed.

Actual contents are good.

[Dan Beam, 2017-06-15 03:59:53]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-06-15 04:00:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 04:03:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497499193525710,
"parent_rev": "14daf81d4cb56c32e83ebeed5a2aed37e36fa6b4", "commit_rev":
"b6f4fde989a97dff96696a0c469a531c4b20557d"}

[commit-bot: I haz the power, 2017-06-15 04:03:20]

Description was changed from

==========
Discourage new use of CallJavascriptFunctionUnsafe() via PRESUBMIT

R=dpranke@chromium.org
BUG=717296
==========

to

==========
Discourage new use of CallJavascriptFunctionUnsafe() via PRESUBMIT

R=dpranke@chromium.org
BUG=717296

Review-Url: https://codereview.chromium.org/2940893003
Cr-Commit-Position: refs/heads/master@{#479596}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6f4fde989a97dff96696a0c469a...
==========

[commit-bot: I haz the power, 2017-06-15 04:03:21]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b6f4fde989a97dff96696a0c469a...