Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Side by Side Diff: PRESUBMIT.py

Issue 2940893003: Discourage new use of CallJavascriptFunctionUnsafe() via PRESUBMIT (Closed)
Patch Set: nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 (), 361 (),
362 ), 362 ),
363 ( 363 (
364 'base::ThreadChecker', 364 'base::ThreadChecker',
365 ( 365 (
366 'Consider using THREAD_CHECKER macros instead of the class directly.', 366 'Consider using THREAD_CHECKER macros instead of the class directly.',
367 ), 367 ),
368 False, 368 False,
369 (), 369 (),
370 ), 370 ),
371 (
372 'CallJavascriptFunctionUnsafe',
373 (
374 "Don't use CallJavascriptFunctionUnsafe() in new code. Instead, use",
375 'AllowJavascript(), OnJavascriptAllowed()/OnJavascriptDisallowed(),',
376 'and CallJavascriptFunction(). See https://goo.gl/qivavq.',
377 ),
378 False,
379 (
380 r'^content[\\\/]browser[\\\/]webui[\\\/]web_ui_impl\.(cc|h)$',
381 r'^content[\\\/]public[\\\/]browser[\\\/]web_ui\.h$',
382 r'^content[\\\/]public[\\\/]test[\\\/]test_web_ui\.(cc|h)$',
383 ),
384 ),
371 ) 385 )
372 386
373 387
374 _IPC_ENUM_TRAITS_DEPRECATED = ( 388 _IPC_ENUM_TRAITS_DEPRECATED = (
375 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' 389 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n'
376 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc') 390 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc')
377 391
378 392
379 _VALID_OS_MACROS = ( 393 _VALID_OS_MACROS = (
380 # Please keep sorted. 394 # Please keep sorted.
(...skipping 2148 matching lines...) Expand 10 before | Expand all | Expand 10 after
2529 output_api, 2543 output_api,
2530 json_url='http://chromium-status.appspot.com/current?format=json')) 2544 json_url='http://chromium-status.appspot.com/current?format=json'))
2531 2545
2532 results.extend( 2546 results.extend(
2533 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) 2547 input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
2534 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2548 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2535 input_api, output_api)) 2549 input_api, output_api))
2536 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2550 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2537 input_api, output_api)) 2551 input_api, output_api))
2538 return results 2552 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698