Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2940883002: Remove redundant condition in policy setup (Closed)

Created:
3 years, 6 months ago by Thiemo Nagel
Modified:
3 years, 5 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant condition in policy setup !initial_policy_fetch_timeout.is_max() ==> allow_failed_policy_fetches_ thus allow_failed_policy_fetches_ can be dropped. At that occasion, also improve the constructor comment and move one member initialization into the class declaration. BUG=none Review-Url: https://codereview.chromium.org/2940883002 Cr-Commit-Position: refs/heads/master@{#482232} Committed: https://chromium.googlesource.com/chromium/src/+/1ade9dfba70113fb2e9898bb187248ed18d07a05

Patch Set 1 #

Patch Set 2 : In-class initialization of base::Timer #

Patch Set 3 : Improve constructor comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Thiemo Nagel
Hey Drew, could you please take a look? Thank you! Thiemo
3 years, 6 months ago (2017-06-14 16:38:48 UTC) #9
Thiemo Nagel
Drew, friendly ping!
3 years, 6 months ago (2017-06-26 09:34:09 UTC) #12
Andrew T Wilson (Slow)
lgtm
3 years, 5 months ago (2017-06-26 10:13:03 UTC) #13
Thiemo Nagel
On 2017/06/26 10:13:03, Andrew T Wilson (Slow) wrote: > lgtm Thank you!
3 years, 5 months ago (2017-06-26 10:14:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940883002/40001
3 years, 5 months ago (2017-06-26 10:14:39 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 10:47:55 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1ade9dfba70113fb2e9898bb1872...

Powered by Google App Engine
This is Rietveld 408576698