Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h

Issue 2940883002: Remove redundant condition in policy setup (Closed)
Patch Set: Improve constructor comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
index e3ef6166e19546c72b5f430889a033dbee8814ed..a7403924b3444b5784654e81e9e98501ea71061b 100644
--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
@@ -44,8 +44,10 @@ class UserCloudPolicyManagerChromeOS : public CloudPolicyManager,
public CloudPolicyService::Observer,
public KeyedService {
public:
- // If |wait_for_policy_fetch| is true, IsInitializationComplete() will return
- // false as long as there hasn't been a successful policy fetch.
+ // If |wait_for_policy_fetch| is true, IsInitializationComplete() is forced to
+ // false until either there has been a successful policy fetch from the server
+ // or |initial_policy_fetch_timeout| has expired. (The timeout may be set to
+ // TimeDelta::Max() to block permanently.)
// |task_runner| is the runner for policy refresh tasks.
// |file_task_runner| is used for file operations. Currently this must be the
// FILE BrowserThread.
@@ -164,7 +166,7 @@ class UserCloudPolicyManagerChromeOS : public CloudPolicyManager,
// A timer that puts a hard limit on the maximum time to wait for the initial
// policy fetch.
- base::Timer policy_fetch_timeout_;
+ base::Timer policy_fetch_timeout_{false, false};
// The pref service to pass to the refresh scheduler on initialization.
PrefService* local_state_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698