Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2940863003: [Sync] Adjust UserEvent proto numbers, add Test message. (Closed)

Created:
3 years, 6 months ago by skym
Modified:
3 years, 6 months ago
Reviewers:
bartekg, Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Adjust UserEvent proto numbers, add Test message. BUG=701032 Review-Url: https://codereview.chromium.org/2940863003 Cr-Commit-Position: refs/heads/master@{#480915} Committed: https://chromium.googlesource.com/chromium/src/+/53d732d4e1201b48894dc529c7712bcd3b48092e

Patch Set 1 #

Patch Set 2 : Updated proto_visitor.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M components/sync/protocol/proto_visitors.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/protocol/user_event_specifics.proto View 1 chunk +9 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (14 generated)
skym
3 years, 6 months ago (2017-06-14 18:10:21 UTC) #6
bartekg
LGTM
3 years, 6 months ago (2017-06-16 03:57:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940863003/20001
3 years, 6 months ago (2017-06-16 19:24:39 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-16 19:24:41 UTC) #13
skym
PTAL
3 years, 6 months ago (2017-06-16 19:25:50 UTC) #15
Patrick Noland
lgtm
3 years, 6 months ago (2017-06-20 18:05:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940863003/20001
3 years, 6 months ago (2017-06-20 18:34:56 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 19:52:50 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53d732d4e1201b48894dc529c771...

Powered by Google App Engine
This is Rietveld 408576698