Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2940843002: Revert of chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. (Closed)

Created:
3 years, 6 months ago by mithro
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. (patchset #1 id:1 of https://codereview.chromium.org/2936193002/ ) Reason for revert: The --debug argument is in the wrong place. Original issue's description: > chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. > > The debug builder has stuff in out/Debug not out/Release so we need the > --debug flag. > > BUG=703894, 524758 > TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org > NOTRY=true > > Review-Url: https://codereview.chromium.org/2936193002 > Cr-Commit-Position: refs/heads/master@{#479354} > Committed: https://chromium.googlesource.com/chromium/src/+/aaf4b270e7509fb7563c0e905c88f3a2dc2cd6d9 TBR=dpranke@chromium.org,mcgreevy@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703894, 524758 Review-Url: https://codereview.chromium.org/2940843002 Cr-Commit-Position: refs/heads/master@{#479358} Committed: https://chromium.googlesource.com/chromium/src/+/c0e77f3ab4c7cee01a67302da149d889e61099ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M testing/buildbot/chromium.webkit.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
mithro
Created Revert of chromium.webkit: Fix WebKit Linux Trusty (dbg) builder.
3 years, 6 months ago (2017-06-14 12:35:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940843002/1
3 years, 6 months ago (2017-06-14 12:35:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c0e77f3ab4c7cee01a67302da149d889e61099ea
3 years, 6 months ago (2017-06-14 12:36:07 UTC) #6
Dirk Pranke
3 years, 6 months ago (2017-06-14 19:38:30 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698