Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2936193002:
chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. (Closed)
Descriptionchromium.webkit: Fix WebKit Linux Trusty (dbg) builder.
The debug builder has stuff in out/Debug not out/Release so we need the
--debug flag.
Now the --debug argument is in the right place!
BUG=703894, 524758
TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
NOTRY=true
Review-Url: https://codereview.chromium.org/2936193002
Cr-Commit-Position: refs/heads/master@{#479362}
Committed: https://chromium.googlesource.com/chromium/src/+/5d3829dc61cf018cbab6ddf57a0d77180d47b034
Patch Set 1 #Patch Set 2 : Put the --debug in the right place. #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tansell@chromium.org
LGTM++
Description was changed from ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org ========== to ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true ==========
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497441756032820, "parent_rev":
"37ee286af065385f62db869e5579de96da1634c0", "commit_rev":
"aaf4b270e7509fb7563c0e905c88f3a2dc2cd6d9"}
Message was sent while issue was closed.
Description was changed from ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true ========== to ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2936193002 Cr-Commit-Position: refs/heads/master@{#479354} Committed: https://chromium.googlesource.com/chromium/src/+/aaf4b270e7509fb7563c0e905c88... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/aaf4b270e7509fb7563c0e905c88...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2940843002/ by tansell@chromium.org. The reason for reverting is: The --debug argument is in the wrong place..
Message was sent while issue was closed.
Description was changed from ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2936193002 Cr-Commit-Position: refs/heads/master@{#479354} Committed: https://chromium.googlesource.com/chromium/src/+/aaf4b270e7509fb7563c0e905c88... ========== to ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true ==========
Description was changed from ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true ========== to ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. Now the --debug argument is in the right place! BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true ==========
The CQ bit was checked by tansell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/2936193002/#ps20001 (title: "Put the --debug in the right place.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497444149339980,
"parent_rev": "a9f6c4e0459c41bbcc70eaa3aac9d1edfbeff3d5", "commit_rev":
"f2b3b09d86ac71091f80a456117c4a696d68539f"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497444149339980,
"parent_rev": "56c9c7065fb31b72c730e90655f1994bf8405557", "commit_rev":
"5d3829dc61cf018cbab6ddf57a0d77180d47b034"}
Message was sent while issue was closed.
Description was changed from ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. Now the --debug argument is in the right place! BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true ========== to ========== chromium.webkit: Fix WebKit Linux Trusty (dbg) builder. The debug builder has stuff in out/Debug not out/Release so we need the --debug flag. Now the --debug argument is in the right place! BUG=703894,524758 TBR=mcgreevy@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2936193002 Cr-Commit-Position: refs/heads/master@{#479362} Committed: https://chromium.googlesource.com/chromium/src/+/5d3829dc61cf018cbab6ddf57a0d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5d3829dc61cf018cbab6ddf57a0d... |
