Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2940773002: [m60 merge] [Cronet] Add null-check to avoid crashing case where no tests are run (Closed)

Created:
3 years, 6 months ago by pauljensen
Modified:
3 years, 6 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[m60 merge] [Cronet] Add null-check to avoid crashing case where no tests are run This can happen in testAndroidTestCaseSetupProperly(), see https://d.android.com/reference/android/test/AndroidTestCase.html#testAndroidTestCaseSetupProperly() which is an empty test case. Chromium avoids this but other test systems don't. Also, remove a redundant loadLibrary call. TBR=xunjieli CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=732625 Review-Url: https://codereview.chromium.org/2909223004 Cr-Original-Commit-Position: refs/heads/master@{#475743} Review-Url: https://codereview.chromium.org/2940773002 . Cr-Commit-Position: refs/branch-heads/3112@{#339} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/800597e6030929371f9171793c0d18fead8ad9b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/BrotliTest.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pauljensen
3 years, 6 months ago (2017-06-14 02:24:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
800597e6030929371f9171793c0d18fead8ad9b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698