Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2909223004: [Cronet] Add null-check to avoid crashing case where no tests are run (Closed)

Created:
3 years, 6 months ago by pauljensen
Modified:
3 years, 6 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add null-check to avoid crashing case where no tests are run This can happen in testAndroidTestCaseSetupProperly(), see https://d.android.com/reference/android/test/AndroidTestCase.html#testAndroidTestCaseSetupProperly() which is an empty test case. Chromium avoids this but other test systems don't. Also, remove a redundant loadLibrary call. R=xunjieli@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2909223004 Cr-Commit-Position: refs/heads/master@{#475743} Committed: https://chromium.googlesource.com/chromium/src/+/7b8a2743d650598f5a326d4794cf04645fb7a232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/BrotliTest.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pauljensen
Helen, PTAL, thank you!
3 years, 6 months ago (2017-05-30 15:45:29 UTC) #2
xunjieli
lgtm
3 years, 6 months ago (2017-05-30 23:50:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909223004/1
3 years, 6 months ago (2017-05-31 00:24:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/451395)
3 years, 6 months ago (2017-05-31 00:41:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909223004/1
3 years, 6 months ago (2017-05-31 02:08:32 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 02:14:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b8a2743d650598f5a326d4794cf...

Powered by Google App Engine
This is Rietveld 408576698