Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2940613003: Remove duplicate entries in methods to diff and predicates to test (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
shend
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate entries in methods to diff and predicates to test This patch ensures that in the case where a method/predicate depends on multiple properties in a generated group the function only appears in the generator once. Diff: https://gist.github.com/nainar/c4d5c74597627e5dcde5f6caad377391/revisions BUG=710938 Review-Url: https://codereview.chromium.org/2940613003 Cr-Commit-Position: refs/heads/master@{#479320} Committed: https://chromium.googlesource.com/chromium/src/+/4e8dd49ac7fa437b85db4086b66fe47841793191

Patch Set 1 #

Patch Set 2 : Merge branch 'rareNonInheritedDataDiff' into removeDuplicated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
nainar
shend@, PTAL? Thanks!
3 years, 6 months ago (2017-06-14 03:09:00 UTC) #4
shend
lgtm
3 years, 6 months ago (2017-06-14 03:10:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940613003/20001
3 years, 6 months ago (2017-06-14 07:45:27 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 07:49:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e8dd49ac7fa437b85db4086b66f...

Powered by Google App Engine
This is Rietveld 408576698