Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2940613003: Remove duplicate entries in methods to diff and predicates to test (Closed)
Patch Set: Merge branch 'rareNonInheritedDataDiff' into removeDuplicated Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py
diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
index 4daaaeb142f9893ff3d32238aeecf81bd2112bf7..ee79f1aa0c147a6d3bd262c10671145e89aaa26a 100755
--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
@@ -224,11 +224,13 @@ def _create_diff_groups(fields_to_diff, methods_to_diff, predicates_to_test, roo
diff_group.fields.append(field)
for entry in methods_to_diff:
for field in root_group.fields:
- if not field.is_inherited_flag and field.property_name in entry['field_dependencies']:
+ if (not field.is_inherited_flag and field.property_name in entry['field_dependencies']
+ and entry['method'] not in diff_group.expressions):
diff_group.expressions.append(entry['method'])
for entry in predicates_to_test:
for field in root_group.fields:
- if not field.is_inherited_flag and field.property_name in entry['field_dependencies']:
+ if (not field.is_inherited_flag and field.property_name in entry['field_dependencies']
+ and entry['predicate'] not in diff_group.predicates):
diff_group.predicates.append(entry['predicate'])
return diff_group
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698