Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2940543002: Fix sound not playing in Dartium checked mode. (Closed)

Created:
3 years, 6 months ago by terry
Modified:
3 years, 6 months ago
Reviewers:
Alan Knight, kevmoo, kasperl
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix sound not playing in Dartium checked mode. Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls. Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations with optional arguments that are Promises. https://github.com/dart-lang/sdk/issues/29810 TBR=alanknight@google.com,kevmoo@google.com Committed: https://github.com/dart-lang/sdk/commit/b3a90540f11b2bc6b96d512b28473b8b5f602dc1

Patch Set 1 #

Patch Set 2 : Fix return type #

Patch Set 3 : Fix return type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -43 lines) Patch
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 2 chunks +14 lines, -27 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_AudioContext.darttemplate View 1 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
terry
Committed patchset #3 (id:40001) manually as b3a90540f11b2bc6b96d512b28473b8b5f602dc1 (presubmit successful).
3 years, 6 months ago (2017-06-13 05:50:23 UTC) #2
kasperl
3 years, 6 months ago (2017-06-13 06:16:01 UTC) #4
Message was sent while issue was closed.
Would it be possible to write a regression test for this?

Powered by Google App Engine
This is Rietveld 408576698