Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294043017: Thwart clickjacking in autofill popups by ignoring double clicks (Closed)

Created:
6 years, 7 months ago by Evan Stade
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, tfarina, browser-components-watch_chromium.org, Dane Wallinga, dyu1, mkwst+watchlist_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Thwart clickjacking in autofill popups by ignoring double clicks BUG=369848 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274452

Patch Set 1 #

Patch Set 2 : way simpler #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/ui/views/autofill/autofill_popup_base_view.cc View 1 2 chunks +1 line, -2 lines 4 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc View 1 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
6 years, 6 months ago (2014-05-30 20:33:55 UTC) #1
Ilya Sherman
I don't seem to have permission to view the bug. Could you please CC me? ...
6 years, 6 months ago (2014-05-30 23:07:15 UTC) #2
Evan Stade
cc'd you on the bug and updated the CL desc. https://codereview.chromium.org/294043017/diff/20001/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc File chrome/browser/ui/views/autofill/autofill_popup_base_view.cc (right): https://codereview.chromium.org/294043017/diff/20001/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc#newcode164 ...
6 years, 6 months ago (2014-06-02 18:30:26 UTC) #3
Ilya Sherman
https://codereview.chromium.org/294043017/diff/20001/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc File chrome/browser/ui/views/autofill/autofill_popup_base_view.cc (right): https://codereview.chromium.org/294043017/diff/20001/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc#newcode164 chrome/browser/ui/views/autofill/autofill_popup_base_view.cc:164: return event.GetClickCount() == 1; On 2014/06/02 18:30:26, Evan Stade ...
6 years, 6 months ago (2014-06-02 22:08:08 UTC) #4
Ilya Sherman
LGTM if you want to handle Mac in a separate CL; but if so, please ...
6 years, 6 months ago (2014-06-02 22:09:09 UTC) #5
Evan Stade
https://codereview.chromium.org/294043017/diff/20001/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc File chrome/browser/ui/views/autofill/autofill_popup_base_view.cc (right): https://codereview.chromium.org/294043017/diff/20001/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc#newcode164 chrome/browser/ui/views/autofill/autofill_popup_base_view.cc:164: return event.GetClickCount() == 1; On 2014/06/02 22:08:08, Ilya Sherman ...
6 years, 6 months ago (2014-06-02 22:19:30 UTC) #6
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 6 months ago (2014-06-02 22:19:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/294043017/20001
6 years, 6 months ago (2014-06-02 22:20:26 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 10:18:40 UTC) #9
Message was sent while issue was closed. 
Change committed as 274452

Powered by Google App Engine
This is Rietveld 408576698