Thwart clickjacking in autofill popups by ignoring double clicks

chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

Index: chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc b/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
index db527c8ec612dd7f1fcff05b1edf3de546b9ae51..ced38990ff6767f987a1b1b0563574168d155d8c 100644
--- a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
+++ b/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
@@ -161,7 +161,7 @@ void AutofillPopupBaseView::OnMouseMoved(const ui::MouseEvent& event) {
 }
 
 bool AutofillPopupBaseView::OnMousePressed(const ui::MouseEvent& event) {
-  return true;
+  return event.GetClickCount() == 1;

[Ilya Sherman, 2014/05/30 23:07:15]

Should there be a corresponding change for Mac?

[Evan Stade, 2014/06/02 18:30:26]

yes

[Ilya Sherman, 2014/06/02 22:08:08]

I meant: Should this CL include a corresponding change for Mac?

[Evan Stade, 2014/06/02 22:19:30]

I could take a stab at the mac code, but I have no way of testing that change so
I'd just as soon file another bug for a follow up on mac.

 }
 
 void AutofillPopupBaseView::OnMouseReleased(const ui::MouseEvent& event) {
@@ -240,5 +240,4 @@ gfx::NativeView AutofillPopupBaseView::container_view() {
   return delegate_->container_view();
 }
 
-
 }  // namespace autofill