Thwart clickjacking in autofill popups by ignoring double clicks

chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_popup_base_view.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/ui/autofill/popup_constants.h"
@@ skipping 143 matching lines @@
 }
 
 void AutofillPopupBaseView::OnMouseMoved(const ui::MouseEvent& event) {
   if (HitTestPoint(event.location()))
     SetSelection(event.location());
   else
     ClearSelection();
 }
 
 bool AutofillPopupBaseView::OnMousePressed(const ui::MouseEvent& event) {
-  return true;
+  return event.GetClickCount() == 1;

[Ilya Sherman, 2014/05/30 23:07:15]

Should there be a corresponding change for Mac?

[Evan Stade, 2014/06/02 18:30:26]

yes

[Ilya Sherman, 2014/06/02 22:08:08]

I meant: Should this CL include a corresponding change for Mac?

[Evan Stade, 2014/06/02 22:19:30]

I could take a stab at the mac code, but I have no way of testing that change so
I'd just as soon file another bug for a follow up on mac.

 }
 
 void AutofillPopupBaseView::OnMouseReleased(const ui::MouseEvent& event) {
   // We only care about the left click.
   if (event.IsOnlyLeftMouseButton() && HitTestPoint(event.location()))
     AcceptSelection(event.location());
 }
 
 void AutofillPopupBaseView::OnGestureEvent(ui::GestureEvent* event) {
   switch (event->type()) {
@@ skipping 58 matching lines @@
 
 void AutofillPopupBaseView::HideController() {
   if (delegate_)
     delegate_->Hide();
 }
 
 gfx::NativeView AutofillPopupBaseView::container_view() {
   return delegate_->container_view();
 }
 
-
 }  // namespace autofill