Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 2940383002: Revert of Enable checking GN missing headers on CQ and waterfall (Closed)

Created:
3 years, 6 months ago by wychen
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable checking GN missing headers on CQ and waterfall (patchset #3 id:40001 of https://codereview.chromium.org/2910603002/ ) Reason for revert: The false negative rate of step check_gn_headers on CQ is higher than expected. Disable it to ease waterfall breakage. BUG=733500 Original issue's description: > Enable checking GN missing headers on CQ and waterfall > > This relands the rest of crrev.com/2903733004. > > Step "check_gn_headers" is enabled on the following bots on CQ: > - linux_chromium_dbg_ng > - linux_chromium_rel_ng > > And also on the following builders on waterfall: > - Linux Builder > - Linux Builder (dbg) > > Note that this script can only be added to bots that have "all" > in "additional_compile_targets". > > BUG=661774, 725877 > > Review-Url: https://codereview.chromium.org/2910603002 > Cr-Commit-Position: refs/heads/master@{#477058} > Committed: https://chromium.googlesource.com/chromium/src/+/00f2b7ed28e3d1d864943497d6aa865ef1cde5e2 TBR=dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=661774, 725877 Review-Url: https://codereview.chromium.org/2940383002 Cr-Commit-Position: refs/heads/master@{#480218} Committed: https://chromium.googlesource.com/chromium/src/+/d8b1ec3835eee2daddcae4c292f9a87683c20001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
wychen
Created Revert of Enable checking GN missing headers on CQ and waterfall
3 years, 6 months ago (2017-06-16 21:56:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940383002/1
3 years, 6 months ago (2017-06-16 21:56:53 UTC) #3
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-16 22:16:51 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 23:33:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8b1ec3835eee2daddcae4c292f9...

Powered by Google App Engine
This is Rietveld 408576698