Enable checking GN missing headers on CQ and waterfall

Enable checking GN missing headers on CQ and waterfall

This relands the rest of crrev.com/2903733004.

Step "check_gn_headers" is enabled on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

And also on the following builders on waterfall:
- Linux Builder
- Linux Builder (dbg)

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774, 725877
Review-Url: https://codereview.chromium.org/2910603002
Cr-Commit-Position: refs/heads/master@{#477058}
Committed: https://chromium.googlesource.com/chromium/src/+/00f2b7ed28e3d1d864943497d6aa865ef1cde5e2

[wychen, 2017-05-26 08:16:11]

wychen@chromium.org changed reviewers:
+ dpranke@chromium.org

[wychen, 2017-05-26 08:16:12]

PTAL.

This is the final part. I plan to land this in the morning some day next week,
so that I can revert it if anything goes wrong.

[Dirk Pranke, 2017-06-03 01:17:32]

lgtm

[wychen, 2017-06-05 17:37:44]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 17:37:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 18:59:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 18:59:41]

Dry run: This issue passed the CQ dry run.

[wychen, 2017-06-05 19:55:56]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-06-05 19:55:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2910603002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-05 19:56:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 20:00:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496692556535550,
"parent_rev": "5f026c277b1c0945bb99b2ffcfcc76f9d10622b2", "commit_rev":
"00f2b7ed28e3d1d864943497d6aa865ef1cde5e2"}

[commit-bot: I haz the power, 2017-06-05 20:00:52]

Description was changed from

==========
Enable checking GN missing headers on CQ and waterfall

This relands the rest of crrev.com/2903733004.

Step "check_gn_headers" is enabled on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

And also on the following builders on waterfall:
- Linux Builder
- Linux Builder (dbg)

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774, 725877
==========

to

==========
Enable checking GN missing headers on CQ and waterfall

This relands the rest of crrev.com/2903733004.

Step "check_gn_headers" is enabled on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

And also on the following builders on waterfall:
- Linux Builder
- Linux Builder (dbg)

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774, 725877

Review-Url: https://codereview.chromium.org/2910603002
Cr-Commit-Position: refs/heads/master@{#477058}
Committed:
https://chromium.googlesource.com/chromium/src/+/00f2b7ed28e3d1d864943497d6aa...
==========

[commit-bot: I haz the power, 2017-06-05 20:00:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/00f2b7ed28e3d1d864943497d6aa...

[wychen, 2017-06-16 21:56:30]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2940383002/ by wychen@chromium.org.

The reason for reverting is: The false negative rate of step check_gn_headers on
CQ is higher than expected. Disable it to ease waterfall breakage.

BUG=733500.