Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2940093002:
Break up chrome/common:common: importer (Closed)
|
Created:
3 years, 6 months ago by manzagop (departed) Modified:
3 years, 6 months ago CC:
chromium-reviews, tfarina Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionBreak up chrome/common:common: importer
This CL breaks off some targets from chrome/common:common.
Context: https://crrev.com/2850863002 introduced a binary size
regression. In order to address it, chrome_logging.* needs to be
pulled out from chrome/common:common to a separate target, but
this turns out to be hard. This CL is a stepping stone.
BUG=717103
Review-Url: https://codereview.chromium.org/2940093002
Cr-Commit-Position: refs/heads/master@{#480098}
Committed: https://chromium.googlesource.com/chromium/src/+/ce85174f53239960c7007e4b6c8bc6bde272f1a5
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : Merge #
Dependent Patchsets: Messages
Total messages: 27 (20 generated)
manzagop@chromium.org changed reviewers: + agrieve@chromium.org
Hi Andrew! Here's a second one. Please have a look. Thanks! P-A
On 2017/06/15 14:59:06, manzagop wrote: > Hi Andrew! > Here's a second one. Please have a look. > Thanks! > P-A lgtm
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Patchset #3 (id:60001) has been deleted
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
manzagop@chromium.org changed reviewers: + gab@chromium.org
Hi Gab! Could you have an OWNERS' look for chrome/common/importer? Thanks! P-A
On 2017/06/16 14:35:23, manzagop wrote: > Hi Gab! > > Could you have an OWNERS' look for chrome/common/importer? r-s lgtm > > Thanks! > > P-A
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Thank you sir!
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2940093002/#ps80001 (title: "Merge")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497630818086720,
"parent_rev": "5904da760ad0345a34a986601f6ae26fb78a4a2e", "commit_rev":
"ce85174f53239960c7007e4b6c8bc6bde272f1a5"}
Message was sent while issue was closed.
Description was changed from ========== Break up chrome/common:common: importer This CL breaks off some targets from chrome/common:common. Context: https://crrev.com/2850863002 introduced a binary size regression. In order to address it, chrome_logging.* needs to be pulled out from chrome/common:common to a separate target, but this turns out to be hard. This CL is a stepping stone. BUG=717103 ========== to ========== Break up chrome/common:common: importer This CL breaks off some targets from chrome/common:common. Context: https://crrev.com/2850863002 introduced a binary size regression. In order to address it, chrome_logging.* needs to be pulled out from chrome/common:common to a separate target, but this turns out to be hard. This CL is a stepping stone. BUG=717103 Review-Url: https://codereview.chromium.org/2940093002 Cr-Commit-Position: refs/heads/master@{#480098} Committed: https://chromium.googlesource.com/chromium/src/+/ce85174f53239960c7007e4b6c8b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/ce85174f53239960c7007e4b6c8b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
