|
|
Created:
3 years, 6 months ago by manzagop (departed) Modified:
3 years, 6 months ago CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionBreak up chrome/common:common: safe_browsing
This CL breaks off some targets from chrome/common:common.
Context: https://crrev.com/2850863002 introduced a binary size
regression. In order to address it, chrome_logging.* needs to be
pulled out from chrome/common:common to a separate target, but
this turns out to be hard. This CL is a stepping stone.
BUG=717103
Review-Url: https://codereview.chromium.org/2935383003
Cr-Commit-Position: refs/heads/master@{#481204}
Committed: https://chromium.googlesource.com/chromium/src/+/55aebefd499df868e163541642068290cf2eea11
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : Merge #Patch Set 4 : fixups #Patch Set 5 : merge #
Messages
Total messages: 40 (24 generated)
manzagop@chromium.org changed reviewers: + agrieve@chromium.org
Hi Andrew, Here is a third. Getting there. Slowly. Thanks! P-A
On 2017/06/15 21:45:15, manzagop wrote: > Hi Andrew, > > Here is a third. Getting there. Slowly. > > Thanks! > > P-A lgtm
manzagop@chromium.org changed reviewers: + vakh@chromium.org
Hi Varun, Could you have an owners' look for chrome/common/safe_browsing? Thanks, Pierre-Antoine
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
lgtm
Thank you for the reviews!
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2935383003/#ps60001 (title: "fixups")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
manzagop@chromium.org changed reviewers: + rdevlin.cronin@chromium.org, thakis@chromium.org
Hi Nico, Devlin, Could you have an owners' look? Nico: chrome\utility\BUILD.gn Devlin: chrome\browser\extensions\BUILD.gn Thanks! Pierre-Antoine
On 2017/06/16 21:43:08, manzagop wrote: > Could you have an owners' look? > Devlin: chrome\browser\extensions\BUILD.gn chrome\browser\extensions\BUILD.gn lgtm
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks Devlin! Friendly ping Nico. :)
lgtm
Thanks for the reviews!
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org, vakh@chromium.org, agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2935383003/#ps80001 (title: "merge")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by manzagop@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498052385556670, "parent_rev": "1a45c520cc585fa6b1756e7a337aca38f70485f1", "commit_rev": "55aebefd499df868e163541642068290cf2eea11"}
Message was sent while issue was closed.
Description was changed from ========== Break up chrome/common:common: safe_browsing This CL breaks off some targets from chrome/common:common. Context: https://crrev.com/2850863002 introduced a binary size regression. In order to address it, chrome_logging.* needs to be pulled out from chrome/common:common to a separate target, but this turns out to be hard. This CL is a stepping stone. BUG=717103 ========== to ========== Break up chrome/common:common: safe_browsing This CL breaks off some targets from chrome/common:common. Context: https://crrev.com/2850863002 introduced a binary size regression. In order to address it, chrome_logging.* needs to be pulled out from chrome/common:common to a separate target, but this turns out to be hard. This CL is a stepping stone. BUG=717103 Review-Url: https://codereview.chromium.org/2935383003 Cr-Commit-Position: refs/heads/master@{#481204} Committed: https://chromium.googlesource.com/chromium/src/+/55aebefd499df868e16354164206... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/55aebefd499df868e16354164206... |