Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2940053004: Add histograms to track which histograms are going negative and why. (Closed)

Created:
3 years, 6 months ago by bcwhite
Modified:
3 years, 6 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histograms to track which histograms are going negative and why. BUG=682680 Review-Url: https://codereview.chromium.org/2940053004 Cr-Commit-Position: refs/heads/master@{#480069} Committed: https://chromium.googlesource.com/chromium/src/+/be9206e0f9f62cb4b9a4159a63b88ff4d0f7fc09

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 4

Patch Set 3 : add units to new histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M base/metrics/persistent_sample_map.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
bcwhite
3 years, 6 months ago (2017-06-15 16:34:56 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/2940053004/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2940053004/diff/20001/tools/metrics/histograms/histograms.xml#newcode79270 tools/metrics/histograms/histograms.xml:79270: +<histogram name="UMA.NegativeSamples.Histogram"> Nit: add enum="HistogramNameHash" Similar to Histogram.BadConstructionArguments - ...
3 years, 6 months ago (2017-06-16 14:52:30 UTC) #9
bcwhite
https://codereview.chromium.org/2940053004/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2940053004/diff/20001/tools/metrics/histograms/histograms.xml#newcode79270 tools/metrics/histograms/histograms.xml:79270: +<histogram name="UMA.NegativeSamples.Histogram"> On 2017/06/16 14:52:30, Alexei Svitkine (slow) wrote: ...
3 years, 6 months ago (2017-06-16 14:59:56 UTC) #12
Alexei Svitkine (slow)
lgtm
3 years, 6 months ago (2017-06-16 15:21:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940053004/40001
3 years, 6 months ago (2017-06-16 15:58:31 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 16:37:34 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/be9206e0f9f62cb4b9a4159a63b8...

Powered by Google App Engine
This is Rietveld 408576698