tools/metrics/histograms/histograms.xml - Issue 2940053004: Add histograms to track which histograms are going negative and why.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2940053004: Add histograms to track which histograms are going negative and why. (Closed)

Patch Set: rebased Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 51751a94b6839889de6c0516e3d72c6b5792f769..278a7373a395514e68679b0202aeb02c9e0e8d6f 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -79267,6 +79267,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="UMA.NegativeSamples.Histogram">

Alexei Svitkine (slow) 2017/06/16 14:52:30 Nit: add enum="HistogramNameHash" Similar to Hist

bcwhite 2017/06/16 14:59:56 I'd completely forgotten about that. I'll have to

+ <owner>asvitkine@chromium.org</owner>

+ <owner>bcwhite@chromium.org</owner>

+ <summary>

+ The lower 32 bits of the ID of the histogram that went negative.

+ </summary>

+</histogram>

+<histogram name="UMA.NegativeSamples.Increment">

Alexei Svitkine (slow) 2017/06/16 14:52:30 Nit: units="increment"

bcwhite 2017/06/16 14:59:56 Done.

+ <owner>asvitkine@chromium.org</owner>

+ <owner>bcwhite@chromium.org</owner>

+ <summary>

+ The amount of increment that caused a sample count to become negative.

+ </summary>

+</histogram>

<owner>asvitkine@chromium.org</owner>

<owner>bcwhite@chromium.org</owner>

« no previous file with comments | « base/metrics/persistent_sample_map.cc ('k') | no next file » | no next file with comments »