Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2939933002: Only call TextChanged on existing AXObjects (Closed)

Created:
3 years, 6 months ago by aboxhall
Modified:
3 years, 6 months ago
CC:
chromium-reviews, dmazzoni+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, sof, eae+blinkwatch, nektarios, yuzo+watch_chromium.org, haraken, blink-reviews-dom_chromium.org, dglazkov+blink, dmazzoni, dougt+watch_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, je_julie, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only call TextChanged on existing AXObjects. This avoids triggering the code which calls UpdateDistribution as part of creating a new AXObject, which was causing issues. This change should cause no behaviour changes, as in cases where an AXObject needs to be created for a text node, its parent will also have a ChildrenChanged notification fired on it, which will cause the appropriate updates to fire. Reverts https://codereview.chromium.org/2926713002/ as the code which causes UpdateDistribution to be called should never run with this change, so we don't need to check whether distribution is dirty any more. BUG=729229, 732200, 734348 Review-Url: https://codereview.chromium.org/2939933002 Cr-Commit-Position: refs/heads/master@{#480792} Committed: https://chromium.googlesource.com/chromium/src/+/0011b9db970f1203f59c4e1b1b52fcdd2035101e

Patch Set 1 #

Total comments: 4

Patch Set 2 : dmazzoni comments #

Patch Set 3 : Experimenting with more aggressively firing notifications #

Patch Set 4 : Fix tests #

Patch Set 5 : Don't fire selection changed notification during document parsing #

Patch Set 6 : Don't fire notifications during parsing #

Patch Set 7 : Update test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -26 lines) Patch
M content/test/data/accessibility/event/menulist-collapse-expected-win.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/contenteditable-notifications.html View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/accessibility-helper.js View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp View 1 2 3 4 5 2 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 2 3 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 44 (29 generated)
aboxhall
3 years, 6 months ago (2017-06-14 16:39:14 UTC) #3
kojii
Superb! Thank you! LGTM!
3 years, 6 months ago (2017-06-14 16:49:01 UTC) #4
dmazzoni
lgtm with nit https://codereview.chromium.org/2939933002/diff/1/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp File third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp (right): https://codereview.chromium.org/2939933002/diff/1/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp#newcode589 third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp:589: if (!axObject) I think you could ...
3 years, 6 months ago (2017-06-14 18:38:15 UTC) #5
aboxhall
https://codereview.chromium.org/2939933002/diff/1/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp File third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp (right): https://codereview.chromium.org/2939933002/diff/1/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp#newcode589 third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp:589: if (!axObject) On 2017/06/14 18:38:14, dmazzoni wrote: > I ...
3 years, 6 months ago (2017-06-14 18:46:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939933002/20001
3 years, 6 months ago (2017-06-14 18:46:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/449738)
3 years, 6 months ago (2017-06-14 19:54:06 UTC) #11
dmazzoni
Keep in mind that LayoutTests differ from when accessibility is enabled in Chrome, in that ...
3 years, 6 months ago (2017-06-15 06:14:38 UTC) #12
aboxhall
On 2017/06/15 06:14:38, dmazzoni wrote: > Keep in mind that LayoutTests differ from when accessibility ...
3 years, 6 months ago (2017-06-15 18:27:14 UTC) #13
dmazzoni
The only failure is AccessibilityEventsMenuListCollapse on Windows, but it's firing an extra (harmless) event, so ...
3 years, 6 months ago (2017-06-20 05:00:12 UTC) #26
Takayoshi Kochi (Google)
This seems also fixing crbug.com/734348 :)
3 years, 6 months ago (2017-06-20 07:58:57 UTC) #30
Takayoshi Kochi (Google)
On 2017/06/20 07:58:57, Takayoshi Kochi (Google) wrote: > This seems also fixing crbug.com/734348 :) Alice, ...
3 years, 6 months ago (2017-06-20 08:00:01 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939933002/120001
3 years, 6 months ago (2017-06-20 11:42:18 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939933002/120001
3 years, 6 months ago (2017-06-20 11:43:26 UTC) #40
aboxhall
On 2017/06/20 08:00:01, Takayoshi Kochi (Google) wrote: > On 2017/06/20 07:58:57, Takayoshi Kochi (Google) wrote: ...
3 years, 6 months ago (2017-06-20 11:43:27 UTC) #41
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 11:49:50 UTC) #44
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/0011b9db970f1203f59c4e1b1b52...

Powered by Google App Engine
This is Rietveld 408576698